Update otel #2261
Update otel #2261
Conversation
| public static final String AZURE_VM = "azure.vm"; | ||
| public static final String AZURE_AKS = "azure.aks"; | ||
| public static final String AZURE_FUNCTIONS = "azure.functions"; | ||
| public static final String AZURE_APP_SERVICE = "azure.app_service"; |
There was a problem hiding this comment.
Those are semconv-related, why wasn't this needed when the semconv update to 1.37.0 was done ? I haven't looked in detail, but do the tests rely directly on those attributes instead of relying on the semconv incubating artifact equivalent ?
There was a problem hiding this comment.
good question - it is indeed related to semconv update - it looks like we got the config wrong and agent overwrites the version
There was a problem hiding this comment.
it's not working for incubating - I'll open a separate PR
+--- io.opentelemetry.semconv:opentelemetry-semconv-incubating -> 1.34.0-alpha
| \--- io.opentelemetry.semconv:opentelemetry-semconv:1.34.0 -> 1.37.0
There was a problem hiding this comment.
why wasn't this needed when the semconv update to 1.37.0 was done
apparently the way we enforce the instrumentation bom overrides the semconv version declared in this project
…emetry-instrumentation-bom-alpha to v2.20.0-alpha
zeitlinger
force-pushed
the
update-otel
branch
from
c4c36b9 to
943d853
Compare
4 participants
Replaces #2260