Gcp add gcr job support #1462
Merged
Gcp add gcr job support #1462
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psx95
force-pushed
the
gcp-add-gcr-job-support
branch
from
4ea7b97 to
c8c421c
Compare
jsuereth
approved these changes
Sep 23, 2024
trask
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Adds support for detecting Google Cloud Run Jobs environment. Cloud Run Jobs currently being detected as
gcp_compute_engine.Existing Issue(s):
Original Issue raised in another repository.
Testing:
Outstanding items:
Need to update the dependency oncom.google.cloud.opentelemetry:detector-resources-supportbefore merging this PR.None .