fix(deps): update testcontainers-java monorepo to v1.20.2 #1482
Conversation
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. |
|
@spockz and @vincentfree mind taking a look -- this testcontainers update required some changes. Hopefully that version bump doesn't hurt the testing of this module.... 🤷🏻 |
|
Docs are here: https://java.testcontainers.org/modules/kafka/ |
|
Thanks. Will take a look soon. Seems to be straightforward but I will validate probably tomorrow |
| .asCompatibleSubstituteFor("apache/kafka"); | ||
| private static final String TOPIC = "span_topic"; | ||
| private KafkaContainer kafka; | ||
| private ConfluentKafkaContainer kafka; |
There was a problem hiding this comment.
I'd use org.testcontainers.kafka.KafkaContainer and set the image to apache/kafka:3.8.0. That is how we handled this in the instrumentation repo.
There was a problem hiding this comment.
Thanks will validate this and update accordingly
There was a problem hiding this comment.
@vincentfree you may the permissions needed to push directly to this PR, but if you do find changes to make, just send a new PR, and renovate will automatically close this PR once we merge yours
There was a problem hiding this comment.
I will implement the suggestions posted by @laurit, using the vendor neutral kafka variant should be preferred over the use of the confluent variant.
|
Closing in favor of the other PR. |
|
For good measure: #1527 |
This PR contains the following updates:
1.20.1->1.20.21.20.1->1.20.2Release Notes
testcontainers/testcontainers-java (org.testcontainers:kafka)
v1.20.2Compare Source
What's Changed
🚀 Features & Enhancements
🐛 Bug Fixes
📖 Documentation
🧹 Housekeeping
📦 Dependency updates
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about these updates again.
This PR was generated by Mend Renovate. View the repository job log.