List component owners on jmx-scraper README #1494
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SylvainJuge
approved these changes
Oct 11, 2024
SylvainJuge
reviewed
Oct 14, 2024
| ## Component owners | ||
|
|
||
| - [Jason Plumb](https://github.com/breedx-splk), Splunk | ||
| - [Robert Niedziela](https://github.com/robsunday), Splunk |
There was a problem hiding this comment.
I'll be added to the owners with #1493 PR, however for Robert you will need to open another PR.
Or alternatively removing him from this readme change until needed.
There was a problem hiding this comment.
this PR is for jmx-scraper, and I think just reflects the existing component_owners.yml:
opentelemetry-java-contrib/.github/component_owners.yml
Lines 44 to 47 in d754367
laurit
approved these changes
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.