Cassandra support and integration test added. #1515
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robsunday
commented
Oct 22, 2024
|
|
||
| public JmxScraperContainer(String otlpEndpoint) { | ||
| super("openjdk:8u272-jre-slim"); | ||
| super("openjdk:8u342-jre-slim"); |
There was a problem hiding this comment.
[for reviewer] Updated to most recent version of Java8 and to support arm64 arch
breedx-splk
reviewed
Oct 22, 2024
| metric -> | ||
| assertGauge( | ||
| metric, | ||
| "cassandra.client.request.range_slice.latency.50p", |
There was a problem hiding this comment.
Bummer that cassandra doesn't provide a histogram. :)
24 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for Cassandra NoSQL DB JMX metrics. The goal of this PR is to port jmx-metrics functionality to jmx-scraper.
JMX Insights has no yaml file for Cassandra and cassandra.yaml file in this PR is created based on cassandra.groovy file from jmx-metrics.
Assertions are copied from jmx-metrics.
Cassandra version is updated from 3.11 used in jmx-scraper to 5.0.2 (the most recent one), however I verified that metrics are correctly gathered on 3.* and 4.* versions. In the future we may consider using multiple versions of tested target system, so we can easily make sure that all of them are supported by single yaml config.
Also jmx-scraper base container image is updated to the most recent java8 version that also supports arm64 arch (for Macs)