GCP Auth extension - allow users to specify quota project ID #1647
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test fails on GitHub CI due to an absence of GoogleCredentials in the environment.
aabmass
reviewed
Jan 16, 2025
...t/java/io/opentelemetry/contrib/gcp/auth/GcpAuthAutoConfigurationCustomizerProviderTest.java
Show resolved
Hide resolved
aabmass
approved these changes
Jan 16, 2025
dashpole
approved these changes
Jan 16, 2025
trask
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR provides an optional argument that lets the users specify a quota project ID.
Existing Issue(s):
Fixes #1645
Testing:
google.cloud.projectas required field added.Documentation:
Updates to the README reflecting the user facing changes added.
Outstanding items:
Add parameterized unit tests to ensure behavior around null or empty values for the project IDs.