Skip to content

Conversation

@psx95
Copy link
Contributor

@psx95 psx95 commented May 20, 2025

Changes

  • Updates the GCP auth config to read from ConfigProperties instead of directly reading environment variables or system properties.
  • Adds log statements informing users of possible misconfiguration of the GOOGLE_OTEL_AUTH_TARGET_SIGNALS.

Existing Issue(s):

Fixes #1903

Testing:

  • Existing unit tests pass indicating that reading from ConfigProperties works as expected.
  • Manually tested this extension with sample application to ensure successful exports.

Documentation:

  • Internal implementation change only, no documentation updates needed.

Outstanding items:

@github-actions github-actions bot requested a review from jsuereth May 20, 2025 21:10
@psx95 psx95 marked this pull request as ready for review May 29, 2025 22:58
@psx95 psx95 requested a review from a team May 29, 2025 22:58
Copy link
Contributor

@jsuereth jsuereth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good. Capitalization handling - here be dragons. Can you update your goals here for supported environment variable names so it's easier to evaluate if this will break in international contexts?

@trask trask added this pull request to the merge queue Jun 5, 2025
Merged via the queue into open-telemetry:main with commit 7b8bbf7 Jun 5, 2025
19 checks passed
@psx95 psx95 deleted the update-auth-extension-config branch June 7, 2025 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Read extension configuration from ConfigProperties

5 participants