[jmx-scraper] Package jmx scraper as a deb/rpm/tar.gz package #1964 #2099
+59
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lemetry#1964 - open-telemetry#1964 - added copyJarForPackage for gradle to copy jar for packaging - added createTarBall to create a packaged tar.gz - added systemd service file
github-actions
bot
requested review from
breedx-splk,
robsunday and
SylvainJuge
…lemetry#1964 - open-telemetry#1964 - added copyJarForPackage for gradle to copy jar for packaging - added createTarBall to create a packaged tar.gz - added systemd service file
|
🔧 The result from spotlessApply was committed to the PR branch. |
breedx-splk
reviewed
Aug 29, 2025
Comment on lines
+17
to
+27
| ## Installation | ||
| jmx-scraper is typically run as a standalone JAR file. | ||
| o use it, you generally need to download the latest JAR from the OpenTelemetry Java Contrib releases page | ||
| or retrieve it as a dependency from a Maven repository. | ||
| Once obtained, you can run it using the Java command line tool. | ||
| Please refer to [Usage](#usage). | ||
|
|
||
| For systemd service, the opentelemetry-jmx-scraper-x.xx.x.tar.gz tar.gz file is available | ||
| with the JAR and a ready to install systemd service file. | ||
|
|
||
|
|
There was a problem hiding this comment.
Whoops, I think this was added to the wrong README.md. Shouldn't be in the maven extension dir I think.
breedx-splk
requested changes
Aug 29, 2025
There was a problem hiding this comment.
So I don't think we should bundle/package a separate .tar or .tgz file -- in the java world the .jar should be enough, and we started publishing that with the last release.
I think that adding the systemd service file is fine, if it comes with docs on how to use it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Existing Issue(s):
#1964
Testing:
Documentation:
updated README.MD
Outstanding items:
If we are going ahead with this, then let me add the .tar.gz to our Release page as well.