Restructure workflows #2135
Merged
Restructure workflows #2135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trask
commented
Aug 19, 2025
| @@ -121,16 +118,6 @@ jobs: | |||
| name: integration-test-results | |||
| path: jmx-metrics/build/reports/tests/integrationTest | |||
|
|
|||
| link-check: | |||
There was a problem hiding this comment.
move into the callers so they can choose not to block merging / snapshots if it fails
trask
commented
Aug 19, 2025
| @@ -139,97 +126,3 @@ jobs: | |||
|
|
|||
| shell-script-check: | |||
| uses: ./.github/workflows/reusable-shell-script-check.yml | |||
|
|
|||
| publish-snapshots: | |||
There was a problem hiding this comment.
moved to build-daily which is only place it's used
trask
commented
Aug 19, 2025
| GPG_PRIVATE_KEY: ${{ secrets.GPG_PRIVATE_KEY }} | ||
| GPG_PASSWORD: ${{ secrets.GPG_PASSWORD }} | ||
|
|
||
| required-status-check: |
There was a problem hiding this comment.
moved to build-pull-request which is only place it's used
trask
commented
Aug 19, 2025
| ) | ||
| run: exit 1 # fail | ||
|
|
||
| workflow-notification: |
There was a problem hiding this comment.
moved to build-daily which is only place it's used
laurit
approved these changes
Aug 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This accomplishes 3 things:
Potentially in future could call the common workflow from release workflow too (similar to instrumentation repo).
GitHub diff isn't great, so I split it into 2 commits, the first commit is just a file rename, so you can review the second commit which then is better (after the rename).