[OpAmp] Move important user-facing classes out of 'internal' package. #2249
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
breedx-splk
changed the title
Contributor
Author
|
Oh, I didn't even see it until now...but it looks like this resovles #2046? |
LikeTheSalad
approved these changes
Sep 12, 2025
Contributor
LikeTheSalad
left a comment
LikeTheSalad
left a comment
There was a problem hiding this comment.
Oh, I didn't even see it until now...but it looks like this resovles #2046?
It does! Thanks for taking a look at this. I'm fine with applying these changes as long as we can keep honoring the warning I added on the README.
trask
approved these changes
Sep 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We discourage external use of any classes inside of
internalpackages, but the main 3 classes described in the readme for the opamp client were also packages asinternal.This PR just moves these 3 classes up and out of internal:
OpampClientOpampClientBuilderRequestServiceNo functional changes.