Use assertj consistently everywhere #2252
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeitlinger
reviewed
Sep 12, 2025
| package io.opentelemetry.contrib.disk.buffering.internal.serialization.deserializers; | ||
|
|
||
| import static org.junit.jupiter.api.Assertions.assertThrows; | ||
| import static org.assertj.core.api.Assertions.assertThatThrownBy; |
Member
There was a problem hiding this comment.
I think assertThatCode is more readable: https://javadoc.io/static/org.assertj/assertj-core/3.25.2/org/assertj/core/api/Assertions.html#assertThatCode(org.assertj.core.api.ThrowableAssert.ThrowingCallable)
Member
Author
There was a problem hiding this comment.
nice, I'll follow-up and try that out everywhere
Member
Author
There was a problem hiding this comment.
@zeitlinger I finally gave this a try, and I wish the API looked like:
assertThatCode(boomCode).throwsInstanceOf(Exception.class)
which reads nicely, vs
assertThatCode(boomCode).isInstanceOf(Exception.class)
which reads oddly to me
zeitlinger
reviewed
Sep 12, 2025
Member
zeitlinger
left a comment
zeitlinger
left a comment
There was a problem hiding this comment.
great improvement for debugging!
jaydeluca
approved these changes
Sep 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applying the style guide in preparation for enabling Copilot reviews.