-
Notifications
You must be signed in to change notification settings - Fork 169
fix version resolution for semconv #2263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
||
| // Version to use to compile code and run tests. | ||
| val DEFAULT_JAVA_VERSION = JavaVersion.VERSION_17 | ||
| val semconvVersion = "1.37.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think we could keep the version in dependencyManagement/build.gradle.kts to keep only having one place where versions are set and updated ? I'm not familiar with gradle resolution details but is there any particular reason we have to do this in otel.java-conventions ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it seems to be a bug in gradle dependency resolution - at least I didn't find a way to keep the version where it is now.
@laurit do you have an idea?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd replace enforcedPlatform with platform. I fail to see a reason why we should enforce this. cc @trask
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this also doesn't help
configurations.configureEach {
val b = isCanBeResolved && !isCanBeConsumed
println("Configuring $name: add=$b")
if (b || name.startsWith("test")) {
extendsFrom(dependencyManagement)
}
}There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @laurit - that was the issue!
|
@laurit it's ready |
Found in #2261
This is the problem
Bug remain even when fixing the currently wrong import statement - adding
-alpha