From 8c33d0e2ecb286483f0ad3d74617d22137b2bcd8 Mon Sep 17 00:00:00 2001 From: Lauri Tulmin Date: Tue, 16 Sep 2025 16:35:12 +0300 Subject: [PATCH 1/2] Fix typo --- .../internal/RuleBasedRoutingSamplerComponentProvider.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/samplers/src/main/java/io/opentelemetry/contrib/sampler/internal/RuleBasedRoutingSamplerComponentProvider.java b/samplers/src/main/java/io/opentelemetry/contrib/sampler/internal/RuleBasedRoutingSamplerComponentProvider.java index 9e7fb4971..b81cdb546 100644 --- a/samplers/src/main/java/io/opentelemetry/contrib/sampler/internal/RuleBasedRoutingSamplerComponentProvider.java +++ b/samplers/src/main/java/io/opentelemetry/contrib/sampler/internal/RuleBasedRoutingSamplerComponentProvider.java @@ -49,7 +49,7 @@ public Sampler create(DeclarativeConfigProperties config) { fallbackSampler = DeclarativeConfiguration.createSampler(fallbackModel); } catch (DeclarativeConfigException e) { throw new DeclarativeConfigException( - "rule_Based_routing sampler failed to create .fallback sampler", e); + "rule_based_routing sampler failed to create .fallback sampler", e); } String spanKindString = config.getString("span_kind", "SERVER"); @@ -92,7 +92,7 @@ public Sampler create(DeclarativeConfigProperties config) { builder.drop(attributeKey, pattern); } else { throw new DeclarativeConfigException( - "rule_based_routing sampler .rules[].action is must be " + "rule_based_routing sampler .rules[].action must be " + ACTION_RECORD_AND_SAMPLE + " or " + ACTION_DROP); From e15e0430057be4a66b8e0c56154ee21a24c75ece Mon Sep 17 00:00:00 2001 From: Lauri Tulmin Date: Tue, 16 Sep 2025 17:01:08 +0300 Subject: [PATCH 2/2] fix test --- .../RuleBasedRoutingSamplerComponentProviderTest.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/samplers/src/test/java/internal/RuleBasedRoutingSamplerComponentProviderTest.java b/samplers/src/test/java/internal/RuleBasedRoutingSamplerComponentProviderTest.java index c39603352..31767262b 100644 --- a/samplers/src/test/java/internal/RuleBasedRoutingSamplerComponentProviderTest.java +++ b/samplers/src/test/java/internal/RuleBasedRoutingSamplerComponentProviderTest.java @@ -173,7 +173,7 @@ static Stream createInvalidArgs() { + "rules:\n" + " - attribute: url.path\n" + " pattern: path\n", - "rule_Based_routing sampler failed to create .fallback sampler"), + "rule_based_routing sampler failed to create .fallback sampler"), Arguments.of( "fallback_sampler:\n" + " always_on:\n" @@ -218,6 +218,6 @@ static Stream createInvalidArgs() { + " - attribute: url.path\n" + " pattern: path\n" + " action: foo\n", - "rule_based_routing sampler .rules[].action is must be RECORD_AND_SAMPLE or DROP")); + "rule_based_routing sampler .rules[].action must be RECORD_AND_SAMPLE or DROP")); } }