From 79513124436be18ac72cf8e9da2b9adb612c0c8c Mon Sep 17 00:00:00 2001 From: Jay DeLuca Date: Wed, 30 Jul 2025 13:58:50 -0400 Subject: [PATCH 1/2] add ci check for failing example --- .github/workflows/build.yml | 25 ++++++++++++++++++++++++- 1 file changed, 24 insertions(+), 1 deletion(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 20b28f64b..ebb46fca0 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -42,6 +42,26 @@ jobs: - run: java -cp sdk-usage/build/libs/opentelemetry-examples-sdk-usage-0.1.0-SNAPSHOT-all.jar io.opentelemetry.sdk.example.ConfigureSpanProcessorExample + test-declarative-configuration-run: + runs-on: ubuntu-latest + steps: + - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2 + + - name: Set up JDK for running Gradle + uses: actions/setup-java@c5195efecf7bdfc987ee8bae7a71cb8b11521c00 # v4.7.1 + with: + distribution: temurin + java-version: 17 + + - name: Set up gradle + uses: gradle/actions/setup-gradle@ac638b010cf58a27ee6c972d7336334ccaf61c96 # v4.4.1 + with: + cache-read-only: ${{ github.event_name == 'pull_request' }} + + - name: Run declarative-configuration + working-directory: declarative-configuration + run: ../gradlew run + # this is not a required check to avoid blocking pull requests if external links break markdown-link-check: uses: ./.github/workflows/reusable-markdown-link-check.yml @@ -49,8 +69,11 @@ jobs: required-status-check: needs: - build + - test-declarative-configuration-run runs-on: ubuntu-latest if: always() steps: - - if: needs.build.result != 'success' + - if: > + needs.build.result != 'success' || + needs.test-declarative-configuration-run.result != 'success' run: exit 1 From e5b95b25ea298f22f2d66c685b6d94c573a6df02 Mon Sep 17 00:00:00 2001 From: Jay DeLuca Date: Wed, 30 Jul 2025 14:05:08 -0400 Subject: [PATCH 2/2] add fix --- .github/workflows/build.yml | 6 ++++-- declarative-configuration/otel-sdk-config.yaml | 14 +++++++------- 2 files changed, 11 insertions(+), 9 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index ebb46fca0..08d6efb1b 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -60,7 +60,9 @@ jobs: - name: Run declarative-configuration working-directory: declarative-configuration - run: ../gradlew run + run: | + export OTEL_EXPERIMENTAL_CONFIG_FILE=$(pwd)/otel-sdk-config.yaml + ../gradlew run # this is not a required check to avoid blocking pull requests if external links break markdown-link-check: @@ -76,4 +78,4 @@ jobs: - if: > needs.build.result != 'success' || needs.test-declarative-configuration-run.result != 'success' - run: exit 1 + run: exit 1 \ No newline at end of file diff --git a/declarative-configuration/otel-sdk-config.yaml b/declarative-configuration/otel-sdk-config.yaml index 5b671e1eb..6ee050d1b 100644 --- a/declarative-configuration/otel-sdk-config.yaml +++ b/declarative-configuration/otel-sdk-config.yaml @@ -1,12 +1,17 @@ # See https://github.com/open-telemetry/opentelemetry-configuration for details on schema and examples -file_format: "0.3" +file_format: "1.0-rc.1" resource: attributes: - name: service.name value: file-configuration-example +propagator: + composite: + - tracecontext: + - baggage: + tracer_provider: processors: - batch: @@ -23,9 +28,4 @@ meter_provider: instrument_type: histogram stream: aggregation: - drop: - -propagator: - composite: - - tracecontext - - baggage + drop: \ No newline at end of file