Skip to content

Commit 02d0ece

Browse files
committed
Pin play smoke test to guice 5
1 parent 5cc8917 commit 02d0ece

File tree

2 files changed

+10
-2
lines changed

2 files changed

+10
-2
lines changed

.github/renovate.json5

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -149,6 +149,14 @@
149149
"matchUpdateTypes": ["major"],
150150
"enabled": false
151151
},
152+
{
153+
// intentionally pinning specifically to guice 5 in the play smoke test
154+
// until we are able to test against the latest version of play
155+
"matchFileNames": ["smoke-tests/images/play/build.gradle.kts"],
156+
"matchPackagePrefixes": ["com.google.inject:", "com.google.inject.extensions:"],
157+
"matchUpdateTypes": ["major"],
158+
"enabled": false
159+
},
152160
{
153161
// intentionally aligning both netty 4.0 and 4.1 version in this convention
154162
"matchFileNames": ["conventions/src/main/kotlin/otel.java-conventions.gradle.kts"],

smoke-tests/images/play/build.gradle.kts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,8 +27,8 @@ dependencies {
2727
implementation("com.typesafe.play:play-guice_$scalaVer:$playVer")
2828
// Guice 5.1 is needed for Java 17 support on Play 2.8, see https://github.com/playframework/playframework/releases/tag/2.8.15
2929
// TODO (trask) remove these version overrides after updating to Play 2.9
30-
implementation("com.google.inject:guice:7.0.0")
31-
implementation("com.google.inject.extensions:guice-assistedinject:7.0.0")
30+
implementation("com.google.inject:guice:5.1.0")
31+
implementation("com.google.inject.extensions:guice-assistedinject:5.1.0")
3232
implementation("com.typesafe.play:play-logback_$scalaVer:$playVer")
3333
implementation("com.typesafe.play:filters-helpers_$scalaVer:$playVer")
3434
}

0 commit comments

Comments
 (0)