Skip to content

Commit 0411349

Browse files
authored
Make a couple of fields final (#17216)
1 parent 7db583f commit 0411349

File tree

1 file changed

+4
-8
lines changed
  • instrumentation/logback/logback-appender-1.0/library/src/main/java/io/opentelemetry/instrumentation/logback/appender/v1_0

1 file changed

+4
-8
lines changed

instrumentation/logback/logback-appender-1.0/library/src/main/java/io/opentelemetry/instrumentation/logback/appender/v1_0/LoggingEventToReplay.java

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,8 @@ class LoggingEventToReplay implements ILoggingEvent {
1818

1919
private final ILoggingEvent loggingEvent;
2020
private final long timeStamp;
21-
private StackTraceElement[] callerData;
22-
private String threadName;
21+
private final StackTraceElement[] callerData;
22+
private final String threadName;
2323

2424
LoggingEventToReplay(
2525
ILoggingEvent loggingEvent,
@@ -29,12 +29,8 @@ class LoggingEventToReplay implements ILoggingEvent {
2929
// The values are copied because the current values are not more available when the log is
3030
// replayed
3131
this.timeStamp = loggingEvent.getTimeStamp();
32-
if (captureExperimentalAttributes) {
33-
this.threadName = loggingEvent.getThreadName();
34-
}
35-
if (captureCodeAttributes) {
36-
this.callerData = loggingEvent.getCallerData();
37-
}
32+
this.threadName = captureExperimentalAttributes ? loggingEvent.getThreadName() : null;
33+
this.callerData = captureCodeAttributes ? loggingEvent.getCallerData() : null;
3834
}
3935

4036
@Override

0 commit comments

Comments
 (0)