Skip to content

Commit 07c1761

Browse files
committed
code.* attributes
1 parent c16de48 commit 07c1761

File tree

2 files changed

+6
-4
lines changed

2 files changed

+6
-4
lines changed

instrumentation/powerjob-4.0/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/powerjob/v4_0/PowerJobBasicProcessorTest.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@
2121
import java.util.ArrayList;
2222
import java.util.List;
2323
import javax.sql.DataSource;
24+
import io.opentelemetry.semconv.incubating.CodeIncubatingAttributes;
2425
import org.junit.jupiter.api.Test;
2526
import org.junit.jupiter.api.extension.RegisterExtension;
2627
import tech.powerjob.official.processors.impl.FileCleanupProcessor;
@@ -342,8 +343,8 @@ private static List<AttributeAssertion> attributeAssertions(
342343
List<AttributeAssertion> attributeAssertions =
343344
new ArrayList<>(
344345
asList(
345-
equalTo(AttributeKey.stringKey("code.namespace"), codeNamespace),
346-
equalTo(AttributeKey.stringKey("code.function"), "process"),
346+
equalTo(CodeIncubatingAttributes.CODE_NAMESPACE, codeNamespace),
347+
equalTo(CodeIncubatingAttributes.CODE_FUNCTION, "process"),
347348
equalTo(AttributeKey.stringKey("job.system"), "powerjob"),
348349
equalTo(AttributeKey.longKey("scheduling.powerjob.job.id"), jobId),
349350
equalTo(AttributeKey.stringKey("scheduling.powerjob.job.type"), jobType)));

instrumentation/xxl-job/xxl-job-common/testing/src/main/java/io/opentelemetry/instrumentation/xxljob/AbstractXxlJobTest.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@
2121
import io.opentelemetry.sdk.trace.data.StatusData;
2222
import java.util.ArrayList;
2323
import java.util.List;
24+
import io.opentelemetry.semconv.incubating.CodeIncubatingAttributes;
2425
import org.junit.jupiter.api.Assumptions;
2526
import org.junit.jupiter.api.BeforeAll;
2627
import org.junit.jupiter.api.Test;
@@ -147,8 +148,8 @@ private static void checkXxlJob(
147148
String codeFunction) {
148149
List<AttributeAssertion> attributeAssertions = new ArrayList<>();
149150
attributeAssertions.addAll(attributeAssertions(glueType));
150-
attributeAssertions.add(equalTo(AttributeKey.stringKey("code.namespace"), codeNamespace));
151-
attributeAssertions.add(equalTo(AttributeKey.stringKey("code.function"), codeFunction));
151+
attributeAssertions.add(equalTo(CodeIncubatingAttributes.CODE_NAMESPACE, codeNamespace));
152+
attributeAssertions.add(equalTo(CodeIncubatingAttributes.CODE_FUNCTION, codeFunction));
152153

153154
checkXxlJob(spanName, statusData, attributeAssertions);
154155
}

0 commit comments

Comments
 (0)