Skip to content

Commit 0ba7177

Browse files
committed
add db client metrics
1 parent d632920 commit 0ba7177

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

instrumentation-api-incubator/src/main/java/io/opentelemetry/instrumentation/api/incubator/semconv/db/DbClientMetrics.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ public final class DbClientMetrics implements OperationListener {
3232

3333
private static final double NANOS_PER_S = TimeUnit.SECONDS.toNanos(1);
3434

35-
private static final ContextKey<State> DB_CLIENT_REQUEST_METRICS_STATE =
35+
private static final ContextKey<State> DB_CLIENT_OPERATION_METRICS_STATE =
3636
ContextKey.named("db-client-metrics-state");
3737

3838
private static final Logger logger = Logger.getLogger(DbClientMetrics.class.getName());
@@ -63,13 +63,13 @@ private DbClientMetrics(Meter meter) {
6363
@Override
6464
public Context onStart(Context context, Attributes startAttributes, long startNanos) {
6565
return context.with(
66-
DB_CLIENT_REQUEST_METRICS_STATE,
66+
DB_CLIENT_OPERATION_METRICS_STATE,
6767
new AutoValue_DbClientMetrics_State(startAttributes, startNanos));
6868
}
6969

7070
@Override
7171
public void onEnd(Context context, Attributes endAttributes, long endNanos) {
72-
State state = context.get(DB_CLIENT_REQUEST_METRICS_STATE);
72+
State state = context.get(DB_CLIENT_OPERATION_METRICS_STATE);
7373
if (state == null) {
7474
logger.log(
7575
FINE,

instrumentation-api-incubator/src/test/java/io/opentelemetry/instrumentation/api/incubator/semconv/db/DbClientMetricsTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ void collectsMetrics() {
3636

3737
OperationListener listener = DbClientMetrics.get().create(meterProvider.get("test"));
3838

39-
Attributes requestAttributes =
39+
Attributes operationAttributes =
4040
Attributes.builder()
4141
.put(DbClientCommonAttributesExtractor.DB_SYSTEM, "myDb")
4242
.put(SqlClientAttributesExtractor.DB_COLLECTION_NAME, "table")
@@ -64,7 +64,7 @@ void collectsMetrics() {
6464
TraceFlags.getSampled(),
6565
TraceState.getDefault())));
6666

67-
Context context1 = listener.onStart(parent, requestAttributes, nanos(100));
67+
Context context1 = listener.onStart(parent, operationAttributes, nanos(100));
6868

6969
assertThat(metricReader.collectAllMetrics()).isEmpty();
7070

0 commit comments

Comments
 (0)