Skip to content

Commit 0dd8f05

Browse files
authored
Tell copilot that only advice classes need to be public (#17199)
1 parent c00b290 commit 0dd8f05

File tree

1 file changed

+1
-3
lines changed

1 file changed

+1
-3
lines changed

.github/agents/knowledge/javaagent-module-patterns.md

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -257,9 +257,7 @@ sufficient for optimization.
257257

258258
### Rules
259259

260-
- Do not flag or change the visibility or `final` modifier on `TypeInstrumentation`,
261-
`InstrumentationModule`, or advice classes. Both `public class` and package-private `class`
262-
(with or without `final`) are acceptable — this is not a style issue in javaagent code.
260+
- Do not flag or change the visibility or `final` modifier on advice classes.
263261
- `typeMatcher()` should match only the types the instrumentation genuinely needs. Prefer
264262
`named("fully.qualified.ClassName")` or `namedOneOf(...)` for single classes.
265263
`extendsClass(...)` and `implementsInterface(...)` are appropriate when the instrumentation

0 commit comments

Comments
 (0)