Skip to content

Commit 0e92840

Browse files
committed
Fix java-http-client tests
1 parent a6ab2c6 commit 0e92840

File tree

3 files changed

+47
-35
lines changed

3 files changed

+47
-35
lines changed
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,16 @@
1+
/*
2+
* Copyright The OpenTelemetry Authors
3+
* SPDX-License-Identifier: Apache-2.0
4+
*/
5+
6+
package io.opentelemetry.javaagent.instrumentation.javahttpclient;
7+
8+
import java.net.http.HttpClient;
9+
10+
class Http1ClientTest extends JavaHttpClientTest {
11+
12+
@Override
13+
protected void configureHttpClientBuilder(HttpClient.Builder httpClientBuilder) {
14+
httpClientBuilder.version(HttpClient.Version.HTTP_1_1);
15+
}
16+
}
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,31 @@
1+
/*
2+
* Copyright The OpenTelemetry Authors
3+
* SPDX-License-Identifier: Apache-2.0
4+
*/
5+
6+
package io.opentelemetry.javaagent.instrumentation.javahttpclient;
7+
8+
import io.opentelemetry.instrumentation.testing.junit.http.HttpClientTestOptions;
9+
import java.net.http.HttpClient;
10+
11+
class Http2ClientTest extends JavaHttpClientTest {
12+
13+
@Override
14+
protected void configureHttpClientBuilder(HttpClient.Builder httpClientBuilder) {
15+
httpClientBuilder.version(HttpClient.Version.HTTP_2);
16+
}
17+
18+
@Override
19+
protected void configure(HttpClientTestOptions.Builder optionsBuilder) {
20+
super.configure(optionsBuilder);
21+
22+
optionsBuilder.setHttpProtocolVersion(
23+
uri -> {
24+
String uriString = uri.toString();
25+
if (uriString.equals("http://localhost:61/") || uriString.equals("https://192.0.2.1/")) {
26+
return "1.1";
27+
}
28+
return "2";
29+
});
30+
}
31+
}

instrumentation/java-http-client/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/javahttpclient/JavaHttpClientTest.java

Lines changed: 0 additions & 35 deletions
Original file line numberDiff line numberDiff line change
@@ -8,9 +8,7 @@
88
import io.opentelemetry.instrumentation.javahttpclient.AbstractJavaHttpClientTest;
99
import io.opentelemetry.instrumentation.testing.junit.InstrumentationExtension;
1010
import io.opentelemetry.instrumentation.testing.junit.http.HttpClientInstrumentationExtension;
11-
import io.opentelemetry.instrumentation.testing.junit.http.HttpClientTestOptions;
1211
import java.net.http.HttpClient;
13-
import org.junit.jupiter.api.Nested;
1412
import org.junit.jupiter.api.extension.RegisterExtension;
1513

1614
public abstract class JavaHttpClientTest extends AbstractJavaHttpClientTest {
@@ -22,37 +20,4 @@ public abstract class JavaHttpClientTest extends AbstractJavaHttpClientTest {
2220
protected HttpClient configureHttpClient(HttpClient httpClient) {
2321
return httpClient;
2422
}
25-
26-
@Nested
27-
static class Http1ClientTest extends JavaHttpClientTest {
28-
29-
@Override
30-
protected void configureHttpClientBuilder(HttpClient.Builder httpClientBuilder) {
31-
httpClientBuilder.version(HttpClient.Version.HTTP_1_1);
32-
}
33-
}
34-
35-
@Nested
36-
static class Http2ClientTest extends JavaHttpClientTest {
37-
38-
@Override
39-
protected void configureHttpClientBuilder(HttpClient.Builder httpClientBuilder) {
40-
httpClientBuilder.version(HttpClient.Version.HTTP_2);
41-
}
42-
43-
@Override
44-
protected void configure(HttpClientTestOptions.Builder optionsBuilder) {
45-
super.configure(optionsBuilder);
46-
47-
optionsBuilder.setHttpProtocolVersion(
48-
uri -> {
49-
String uriString = uri.toString();
50-
if (uriString.equals("http://localhost:61/")
51-
|| uriString.equals("https://192.0.2.1/")) {
52-
return "1.1";
53-
}
54-
return "2";
55-
});
56-
}
57-
}
5823
}

0 commit comments

Comments
 (0)