review

Author: trask

instrumentation/reactor/reactor-netty/reactor-netty-1.0/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/reactornetty/v1_0/ReactorNettyHttpClientTest.java

@@ -33,10 +33,11 @@ protected HttpClient createHttpClient() {
   protected void configure(HttpClientTestOptions.Builder optionsBuilder) {
     super.configure(optionsBuilder);
 
-    boolean isWindows = OS.WINDOWS.isCurrentOs();
-
-    // Only run single connection tests on Linux due to networking stack differences
-    if (!isWindows) {
+    if (OS.WINDOWS.isCurrentOs()) {
+      // Disable remote connection tests on Windows due to reactor-netty creating extra spans
+      optionsBuilder.setTestRemoteConnection(false);
+    } else {
+      // Only run single connection tests on Linux due to networking stack differences
       optionsBuilder.setSingleConnectionFactory(
           (host, port) -> {
             HttpClient httpClient =
@@ -60,11 +61,6 @@ protected void configure(HttpClientTestOptions.Builder optionsBuilder) {
                     .code();
           });
     }
-
-    // Disable remote connection tests on Windows due to reactor-netty creating extra spans
-    if (isWindows) {
-      optionsBuilder.setTestRemoteConnection(false);
-    }
   }
 
   @Override