Skip to content

Commit 158f8d4

Browse files
shalkjaydeluca
andauthored
Apply suggestions from code review
Co-authored-by: Jay DeLuca <[email protected]>
1 parent c590597 commit 158f8d4

File tree

1 file changed

+7
-6
lines changed
  • instrumentation/twilio-6.6/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/twilio

1 file changed

+7
-6
lines changed

instrumentation/twilio-6.6/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/twilio/TwilioClientTest.java

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -157,13 +157,13 @@ void synchronousMessage() {
157157
testing.waitAndAssertTraces(
158158
trace ->
159159
trace.hasSpansSatisfyingExactly(
160-
span -> span.hasName("test").hasNoParent(),
160+
span -> span.hasName("test").hasNoParent().hasAttributes(Attributes.empty()),
161161
span ->
162162
span.hasName("MessageCreator.create")
163163
.hasKind(CLIENT)
164164
.hasAttributesSatisfyingExactly(
165165
equalTo(
166-
AttributeKey.stringKey("twilio.type"),
166+
stringKey("twilio.type"),
167167
"com.twilio.rest.api.v2010.account.Message"),
168168
equalTo(
169169
AttributeKey.stringKey("twilio.account"),
@@ -203,6 +203,7 @@ void synchronousCall() throws URISyntaxException {
203203
span ->
204204
span.hasName("CallCreator.create")
205205
.hasKind(CLIENT)
206+
.hasAttributes(Attributes.empty())
206207
.hasAttributesSatisfyingExactly(
207208
equalTo(
208209
AttributeKey.stringKey("twilio.type"),
@@ -247,7 +248,7 @@ void httpClient() throws IOException {
247248
testing.waitAndAssertTraces(
248249
trace ->
249250
trace.hasSpansSatisfyingExactly(
250-
span -> span.hasName("test").hasNoParent(),
251+
span -> span.hasName("test").hasNoParent().hasAttributes(Attributes.empty()),
251252
span ->
252253
span.hasName("MessageCreator.create")
253254
.hasKind(CLIENT)
@@ -303,7 +304,7 @@ void httpClientRetry() throws IOException {
303304
testing.waitAndAssertTraces(
304305
trace ->
305306
trace.hasSpansSatisfyingExactly(
306-
span -> span.hasName("test").hasNoParent(),
307+
span -> span.hasName("test").hasNoParent().hasAttributes(Attributes.empty()),
307308
span ->
308309
span.hasName("MessageCreator.create")
309310
.hasKind(CLIENT)
@@ -360,7 +361,7 @@ void httpClientRetryAsync() throws Exception {
360361
testing.waitAndAssertTraces(
361362
trace ->
362363
trace.hasSpansSatisfyingExactly(
363-
span -> span.hasName("test").hasNoParent(),
364+
span -> span.hasName("test").hasNoParent().hasAttributes(Attributes.empty()),
364365
span ->
365366
span.hasName("MessageCreator.createAsync")
366367
.hasKind(CLIENT)
@@ -486,7 +487,7 @@ void asynchronousCall() throws Exception {
486487
testing.waitAndAssertTraces(
487488
trace ->
488489
trace.hasSpansSatisfyingExactly(
489-
span -> span.hasName("test").hasNoParent(),
490+
span -> span.hasName("test").hasNoParent().hasAttributes(Attributes.empty()),
490491
span ->
491492
span.hasName("MessageCreator.createAsync")
492493
.hasKind(CLIENT)

0 commit comments

Comments
 (0)