Skip to content

Commit 1607ea3

Browse files
committed
fix ci && add test
1 parent 7e210a2 commit 1607ea3

File tree

1 file changed

+6
-0
lines changed
  • instrumentation/vertx/vertx-kafka-client-3.6/testing/src/main/java/io/opentelemetry/javaagent/instrumentation/vertx/kafka

1 file changed

+6
-0
lines changed

instrumentation/vertx/vertx-kafka-client-3.6/testing/src/main/java/io/opentelemetry/javaagent/instrumentation/vertx/kafka/AbstractVertxKafkaTest.java

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -59,6 +59,9 @@ public abstract class AbstractVertxKafkaTest {
5959
private static final AttributeKey<String> MESSAGING_CLIENT_ID =
6060
AttributeKey.stringKey("messaging.client_id");
6161

62+
protected static final AttributeKey<String> MESSAGING_KAFKA_BOOTSTRAP_SERVERS =
63+
AttributeKey.stringKey("messaging.kafka.bootstrap.servers");
64+
6265
KafkaContainer kafka;
6366
Vertx vertx;
6467
protected KafkaProducer<String, String> kafkaProducer;
@@ -179,6 +182,7 @@ protected static List<AttributeAssertion> sendAttributes(
179182
equalTo(MESSAGING_SYSTEM, KAFKA),
180183
equalTo(MESSAGING_DESTINATION_NAME, record.topic()),
181184
equalTo(MESSAGING_OPERATION, "publish"),
185+
satisfies(MESSAGING_KAFKA_BOOTSTRAP_SERVERS, AbstractStringAssert::isNotEmpty),
182186
satisfies(MESSAGING_CLIENT_ID, stringAssert -> stringAssert.startsWith("producer")),
183187
satisfies(MESSAGING_DESTINATION_PARTITION_ID, AbstractStringAssert::isNotEmpty),
184188
satisfies(MESSAGING_KAFKA_MESSAGE_OFFSET, AbstractLongAssert::isNotNegative)));
@@ -205,6 +209,7 @@ private List<AttributeAssertion> batchConsumerAttributes(String topic, String op
205209
equalTo(MESSAGING_SYSTEM, KAFKA),
206210
equalTo(MESSAGING_DESTINATION_NAME, topic),
207211
equalTo(MESSAGING_OPERATION, operation),
212+
satisfies(MESSAGING_KAFKA_BOOTSTRAP_SERVERS, AbstractStringAssert::isNotEmpty),
208213
satisfies(MESSAGING_CLIENT_ID, stringAssert -> stringAssert.startsWith("consumer")),
209214
satisfies(MESSAGING_BATCH_MESSAGE_COUNT, AbstractLongAssert::isPositive)));
210215
if (hasConsumerGroup()) {
@@ -221,6 +226,7 @@ protected List<AttributeAssertion> processAttributes(KafkaProducerRecord<String,
221226
equalTo(MESSAGING_SYSTEM, KAFKA),
222227
equalTo(MESSAGING_DESTINATION_NAME, record.topic()),
223228
equalTo(MESSAGING_OPERATION, "process"),
229+
satisfies(MESSAGING_KAFKA_BOOTSTRAP_SERVERS, AbstractStringAssert::isNotEmpty),
224230
satisfies(MESSAGING_CLIENT_ID, stringAssert -> stringAssert.startsWith("consumer")),
225231
satisfies(MESSAGING_DESTINATION_PARTITION_ID, AbstractStringAssert::isNotEmpty),
226232
satisfies(MESSAGING_KAFKA_MESSAGE_OFFSET, AbstractLongAssert::isNotNegative)));

0 commit comments

Comments
 (0)