Skip to content

Commit 172906e

Browse files
authored
Apply suggestions from code review
1 parent 389768b commit 172906e

File tree

3 files changed

+5
-5
lines changed

3 files changed

+5
-5
lines changed

instrumentation/jmx-metrics/library/src/test/java/io/opentelemetry/instrumentation/jmx/engine/UnitConverterTest.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -67,9 +67,9 @@ void shouldHandleUnsupportedConversion(String sourceUnit, String targetUnit) {
6767
private static Stream<Arguments> shouldSkipConversionWhenSourceUnitNotSpecifiedProvider() {
6868
return Stream.of(
6969
// sourceUnit, targetUnit
70-
Arguments.of(null, "s"), // null -> "s"
71-
Arguments.of("", "s"), // "" -> "s"
72-
Arguments.of("1", "")); // empty target unit
70+
Arguments.of(null, "s"),
71+
Arguments.of("", "s"),
72+
Arguments.of("1", ""));
7373
}
7474

7575
@ParameterizedTest

javaagent-tooling/src/test/java/io/opentelemetry/javaagent/tooling/OpenTelemetryInstallerTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ private static Stream<Arguments> defaultEnabledInDeclarativeConfigPropertiesBrid
4949
// propertyValue, expected, fail
5050
Arguments.of("default", true, false),
5151
Arguments.of("none", false, false),
52-
Arguments.of(null, true, false), // null value means property is not set
52+
Arguments.of(null, true, false),
5353
Arguments.of("invalid", false, true));
5454
}
5555

javaagent-tooling/src/test/java/io/opentelemetry/javaagent/tooling/SpanLoggingCustomizerProviderTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ private static Stream<Arguments> addSpanLoggingExporterProvider() {
2727
// propertyValue, alreadyAdded, expected
2828
Arguments.of("true", false, true),
2929
Arguments.of("false", false, false),
30-
Arguments.of(null, false, false), // null value means property is not set
30+
Arguments.of(null, false, false),
3131
Arguments.of("invalid", false, false),
3232
Arguments.of("true", true, true));
3333
}

0 commit comments

Comments
 (0)