Skip to content

Commit 182cb53

Browse files
committed
post-review changes
1 parent a8bcf29 commit 182cb53

File tree

2 files changed

+3
-15
lines changed

2 files changed

+3
-15
lines changed

instrumentation/internal/internal-class-loader/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/internal/classloader/LoadInjectedClassInstrumentation.java

Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -60,22 +60,14 @@ public static class LoadClassAdvice {
6060
@Advice.OnMethodEnter(skipOn = Advice.OnNonDefaultValue.class)
6161
public static Class<?> onEnter(
6262
@Advice.This ClassLoader classLoader, @Advice.Argument(0) String name) {
63-
Class<?> helperClass = InjectedClassHelper.loadHelperClass(classLoader, name);
64-
if (helperClass != null) {
65-
return helperClass;
66-
}
67-
return null;
63+
return InjectedClassHelper.loadHelperClass(classLoader, name);
6864
}
6965

7066
@AssignReturned.ToReturned
7167
@Advice.OnMethodExit(onThrowable = Throwable.class)
7268
public static Class<?> onExit(
7369
@Advice.Return Class<?> originalResult, @Advice.Enter Class<?> loadedClass) {
74-
Class<?> result = originalResult;
75-
if (loadedClass != null) {
76-
result = loadedClass;
77-
}
78-
return result;
70+
return loadedClass != null ? loadedClass : originalResult;
7971
}
8072
}
8173
}

instrumentation/internal/internal-eclipse-osgi-3.6/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/internal/osgi/EclipseOsgiInstrumentation.java

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -57,11 +57,7 @@ public static boolean onEnter(@Advice.Argument(0) String packageName) {
5757
@Advice.OnMethodExit(onThrowable = Throwable.class, suppress = Throwable.class)
5858
public static boolean onExit(
5959
@Advice.Return boolean originalResult, @Advice.Enter boolean inClassLoaderMatcher) {
60-
boolean result = originalResult;
61-
if (inClassLoaderMatcher) {
62-
result = false;
63-
}
64-
return result;
60+
return inClassLoaderMatcher ? false : originalResult;
6561
}
6662
}
6763
}

0 commit comments

Comments
 (0)