Skip to content

Commit 1cda7fa

Browse files
committed
add test
1 parent dbcf795 commit 1cda7fa

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

instrumentation/spring/spring-boot-autoconfigure/src/main/java/io/opentelemetry/instrumentation/spring/autoconfigure/OpenTelemetryAutoConfiguration.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55

66
package io.opentelemetry.instrumentation.spring.autoconfigure;
77

8+
import io.opentelemetry.api.GlobalOpenTelemetry;
89
import io.opentelemetry.api.OpenTelemetry;
910
import io.opentelemetry.api.trace.TracerProvider;
1011
import io.opentelemetry.instrumentation.api.incubator.config.internal.InstrumentationConfig;
@@ -161,6 +162,9 @@ public OpenTelemetry openTelemetry(
161162
DeclarativeConfiguration.create(
162163
model, new OpenTelemetrySdkComponentLoader(applicationContext));
163164
Runtime.getRuntime().addShutdownHook(new Thread(sdk::close));
165+
// todo there is no equivalent to https://github.com/open-telemetry/opentelemetry-java/blob/7655192df504d28da2d2013f2fc49ec44ef6202e/sdk-extensions/autoconfigure/src/main/java/io/opentelemetry/sdk/autoconfigure/LoggerProviderConfiguration.java#L96
166+
// so we get a NPE when there is no global OpenTelemetry instance set
167+
GlobalOpenTelemetry.set(sdk);
164168
logStart();
165169
return sdk;
166170
}

0 commit comments

Comments
 (0)