pr review

Author: zeitlinger

buildscripts/codenarc.groovy

@@ -275,6 +275,7 @@ ruleset {
   JUnitUnnecessarySetUp
   JUnitUnnecessaryTearDown
   JUnitUnnecessaryThrowsException
+  SpockIgnoreRestUsed
   UnnecessaryFail
   UseAssertEqualsInsteadOfAssertTrue
   UseAssertFalseInsteadOfNegation

docs/contributing/writing-instrumentation.md

@@ -226,7 +226,7 @@ a `testImplementation` dependency on the `testing` submodule. Then, create a tes
 the abstract test class from `testing`. You should implement the abstract `configure()` method to
 initialize the library using the exposed mechanism to register interceptors/listeners, perhaps a
 method like `registerInterceptor`. You can also wrap the object with the instrumentation decorator.
-Make sure that the test class is marked as a library instrumentation test. Both JUnit test
+Make sure that the test class is marked as a library instrumentation test. JUnit test
 utilities expose a way to specify whether you're running a library or javaagent test. If the tests
 pass, the library instrumentation is working.
 

muzzle/src/test/java/io/opentelemetry/javaagent/tooling/muzzle/MuzzleWeakReferenceTestUtil.java

@@ -16,9 +16,6 @@
 
 public class MuzzleWeakReferenceTestUtil {
 
-  // Spock holds strong references to all local variables. For weak reference testing we must create
-  // our strong references away from Spock in this java class.
-  // Even returning a WeakReference<ClassLoader> is enough for spock to create a strong ref.
   public static boolean classLoaderRefIsGarbageCollected()
       throws InterruptedException, TimeoutException {
     ClassLoader loader = new URLClassLoader(new URL[0], null);

testing-common/src/main/java/io/opentelemetry/instrumentation/test/utils/ClasspathUtils.java

@@ -93,7 +93,6 @@ private static void addToJar(String resourceName, byte[] bytes, JarOutputStream
     jarOutputStream.closeEntry();
   }
 
-  // Moved this to a java class because groovy was adding a hard ref to classLoader
   public static boolean isClassLoaded(String className, ClassLoader classLoader) {
     try {
       Method findLoadedClassMethod =

testing-common/src/main/java/io/opentelemetry/instrumentation/testing/GlobalTraceUtil.java

@@ -10,7 +10,7 @@
 import io.opentelemetry.instrumentation.testing.util.ThrowingSupplier;
 
 /**
- * Can be useful when you need to start a span {@link
+ * Can be useful when you need to start a span and {@link
  * io.opentelemetry.instrumentation.testing.junit.InstrumentationExtension} is not available.
  */
 public final class GlobalTraceUtil {