Skip to content

Commit 1f4d357

Browse files
committed
Made changes based off comments
1 parent a3fd09c commit 1f4d357

File tree

4 files changed

+2
-33
lines changed

4 files changed

+2
-33
lines changed

instrumentation/camunda/camunda-7.0/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/camunda/v7_0/behavior/CamundaCallableElementActivityBehaviorInstrumentation.java

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -73,10 +73,6 @@ public static void addTracingEnter(
7373
request.setActivityName(Optional.ofNullable(execution.getCurrentActivityName()));
7474
request.setBusinessKey(Optional.ofNullable(execution.getProcessBusinessKey()));
7575

76-
if (Java8BytecodeBridge.currentContext() == Java8BytecodeBridge.rootContext()) {
77-
// log
78-
}
79-
8076
Context parentContext =
8177
getOpentelemetry()
8278
.getPropagators()

instrumentation/camunda/camunda-7.0/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/camunda/v7_0/jobs/CamundaAsyncContinuationJobHandlerInstrumentation.java

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -25,11 +25,6 @@
2525

2626
public class CamundaAsyncContinuationJobHandlerInstrumentation implements TypeInstrumentation {
2727

28-
@Override
29-
public ElementMatcher<ClassLoader> classLoaderOptimization() {
30-
return hasClassesNamed("org.camunda.bpm.engine.impl.jobexecutor.AsyncContinuationJobHandler");
31-
}
32-
3328
@Override
3429
public ElementMatcher<TypeDescription> typeMatcher() {
3530
return ElementMatchers.named(

instrumentation/camunda/camunda-7.0/library/src/main/java/io/opentelemetry/instrumentation/camunda/v7_0/behavior/CamundaActivityExecutionGetter.java

Lines changed: 0 additions & 23 deletions
This file was deleted.

instrumentation/camunda/camunda-7.0/testing/src/main/java/io/opentelemetry/instrumentation/camunda/v7_0/AbstractCamundaTest.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,8 @@ void testProcessExecutionAllSuccess() {
7373
span.hasName("testMainProcess")
7474
.hasKind(SpanKind.INTERNAL)
7575
.hasAttributesSatisfyingExactly(
76-
equalTo(stringKey("camunda.processdefinitionkey"), "testMainProcess")),
76+
equalTo(stringKey("camunda.processdefinitionkey"), "testMainProcess"))
77+
.hasNoParent(),
7778
span ->
7879
span.hasName("Get Product Info Task")
7980
.hasKind(SpanKind.INTERNAL)

0 commit comments

Comments
 (0)