Skip to content

Commit 1f6d322

Browse files
committed
post-review changes
1 parent 41814e6 commit 1f6d322

File tree

4 files changed

+7
-11
lines changed

4 files changed

+7
-11
lines changed

instrumentation/jsf/jsf-mojarra-1.2/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/mojarra/ActionListenerImplInstrumentation.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@
1010

1111
import io.opentelemetry.context.Context;
1212
import io.opentelemetry.context.Scope;
13-
import io.opentelemetry.javaagent.bootstrap.Java8BytecodeBridge;
1413
import io.opentelemetry.javaagent.extension.instrumentation.TypeInstrumentation;
1514
import io.opentelemetry.javaagent.extension.instrumentation.TypeTransformer;
1615
import io.opentelemetry.javaagent.instrumentation.jsf.javax.JsfRequest;
@@ -50,7 +49,7 @@ private AdviceScope(JsfRequest request, Context context, Scope scope) {
5049

5150
@Nullable
5251
public static AdviceScope start(@Advice.Argument(0) ActionEvent event) {
53-
Context parentContext = Java8BytecodeBridge.currentContext();
52+
Context parentContext = Context.current();
5453
JsfRequest request = new JsfRequest(event);
5554
if (!request.shouldStartSpan() || !instrumenter().shouldStart(parentContext, request)) {
5655
return null;

instrumentation/jsf/jsf-mojarra-3.0/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/mojarra/v3_0/ActionListenerImplInstrumentation.java

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@
1010

1111
import io.opentelemetry.context.Context;
1212
import io.opentelemetry.context.Scope;
13-
import io.opentelemetry.javaagent.bootstrap.Java8BytecodeBridge;
1413
import io.opentelemetry.javaagent.extension.instrumentation.TypeInstrumentation;
1514
import io.opentelemetry.javaagent.extension.instrumentation.TypeTransformer;
1615
import io.opentelemetry.javaagent.instrumentation.jsf.jakarta.JsfRequest;
@@ -49,8 +48,8 @@ private AdviceScope(JsfRequest request, Context context, Scope scope) {
4948
}
5049

5150
@Nullable
52-
public static AdviceScope start(@Advice.Argument(0) ActionEvent event) {
53-
Context parentContext = Java8BytecodeBridge.currentContext();
51+
public static AdviceScope start(ActionEvent event) {
52+
Context parentContext = Context.current();
5453
JsfRequest request = new JsfRequest(event);
5554
if (!request.shouldStartSpan() || !instrumenter().shouldStart(parentContext, request)) {
5655
return null;

instrumentation/jsf/jsf-myfaces-1.2/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/myfaces/ActionListenerImplInstrumentation.java

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@
1010

1111
import io.opentelemetry.context.Context;
1212
import io.opentelemetry.context.Scope;
13-
import io.opentelemetry.javaagent.bootstrap.Java8BytecodeBridge;
1413
import io.opentelemetry.javaagent.extension.instrumentation.TypeInstrumentation;
1514
import io.opentelemetry.javaagent.extension.instrumentation.TypeTransformer;
1615
import io.opentelemetry.javaagent.instrumentation.jsf.javax.JsfRequest;
@@ -49,8 +48,8 @@ private AdviceScope(JsfRequest request, Context context, Scope scope) {
4948
}
5049

5150
@Nullable
52-
public static AdviceScope start(@Advice.Argument(0) ActionEvent event) {
53-
Context parentContext = Java8BytecodeBridge.currentContext();
51+
public static AdviceScope start(ActionEvent event) {
52+
Context parentContext = Context.current();
5453
JsfRequest request = new JsfRequest(event);
5554
if (!request.shouldStartSpan() || !instrumenter().shouldStart(parentContext, request)) {
5655
return null;

instrumentation/jsf/jsf-myfaces-3.0/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/myfaces/v3_0/ActionListenerImplInstrumentation.java

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@
1010

1111
import io.opentelemetry.context.Context;
1212
import io.opentelemetry.context.Scope;
13-
import io.opentelemetry.javaagent.bootstrap.Java8BytecodeBridge;
1413
import io.opentelemetry.javaagent.extension.instrumentation.TypeInstrumentation;
1514
import io.opentelemetry.javaagent.extension.instrumentation.TypeTransformer;
1615
import io.opentelemetry.javaagent.instrumentation.jsf.jakarta.JsfRequest;
@@ -49,8 +48,8 @@ private AdviceScope(JsfRequest request, Context context, Scope scope) {
4948
}
5049

5150
@Nullable
52-
public static AdviceScope start(@Advice.Argument(0) ActionEvent event) {
53-
Context parentContext = Java8BytecodeBridge.currentContext();
51+
public static AdviceScope start(ActionEvent event) {
52+
Context parentContext = Context.current();
5453
JsfRequest request = new JsfRequest(event);
5554
if (!request.shouldStartSpan() || !instrumenter().shouldStart(parentContext, request)) {
5655
return null;

0 commit comments

Comments
 (0)