Skip to content

Commit 236a42f

Browse files
author
Mateusz Rzeszutek
authored
Make HttpStatusConverter package private (#5268)
1 parent aa2ac33 commit 236a42f

File tree

3 files changed

+22
-54
lines changed

3 files changed

+22
-54
lines changed

instrumentation-api/src/main/java/io/opentelemetry/instrumentation/api/instrumenter/http/HttpClientStatusConverter.java

Lines changed: 0 additions & 25 deletions
This file was deleted.

instrumentation-api/src/main/java/io/opentelemetry/instrumentation/api/instrumenter/http/HttpServerStatusConverter.java

Lines changed: 0 additions & 25 deletions
This file was deleted.

instrumentation-api/src/main/java/io/opentelemetry/instrumentation/api/instrumenter/http/HttpStatusConverter.java

Lines changed: 22 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,10 +7,28 @@
77

88
import io.opentelemetry.api.trace.StatusCode;
99

10-
public interface HttpStatusConverter {
10+
// https://github.com/open-telemetry/opentelemetry-specification/blob/master/specification/trace/semantic_conventions/http.md#status
11+
enum HttpStatusConverter {
12+
SERVER {
13+
@Override
14+
StatusCode statusFromHttpStatus(int httpStatus) {
15+
if (httpStatus >= 100 && httpStatus < 500) {
16+
return StatusCode.UNSET;
17+
}
1118

12-
HttpStatusConverter SERVER = HttpServerStatusConverter.INSTANCE;
13-
HttpStatusConverter CLIENT = HttpClientStatusConverter.INSTANCE;
19+
return StatusCode.ERROR;
20+
}
21+
},
22+
CLIENT {
23+
@Override
24+
StatusCode statusFromHttpStatus(int httpStatus) {
25+
if (httpStatus >= 100 && httpStatus < 400) {
26+
return StatusCode.UNSET;
27+
}
1428

15-
StatusCode statusFromHttpStatus(int httpStatus);
29+
return StatusCode.ERROR;
30+
}
31+
};
32+
33+
abstract StatusCode statusFromHttpStatus(int httpStatus);
1634
}

0 commit comments

Comments
 (0)