Skip to content

Commit 23ec4aa

Browse files
authored
Remove duplicate virutal field (#15475)
1 parent 19f0b6d commit 23ec4aa

File tree

3 files changed

+6
-16
lines changed

3 files changed

+6
-16
lines changed

instrumentation/servlet/servlet-3.0/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/servlet/v3_0/Servlet3FilterInitAdvice.java

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55

66
package io.opentelemetry.javaagent.instrumentation.servlet.v3_0;
77

8-
import static io.opentelemetry.javaagent.instrumentation.servlet.v3_0.Servlet3Singletons.FILTER_MAPPING_RESOLVER_FACTORY;
8+
import static io.opentelemetry.javaagent.instrumentation.servlet.v3_0.Servlet3Singletons.FILTER_MAPPING_RESOLVER;
99

1010
import javax.servlet.Filter;
1111
import javax.servlet.FilterConfig;
@@ -20,7 +20,6 @@ public static void filterInit(
2020
if (filterConfig == null) {
2121
return;
2222
}
23-
FILTER_MAPPING_RESOLVER_FACTORY.set(
24-
filter, new Servlet3FilterMappingResolverFactory(filterConfig));
23+
FILTER_MAPPING_RESOLVER.set(filter, new Servlet3FilterMappingResolverFactory(filterConfig));
2524
}
2625
}

instrumentation/servlet/servlet-3.0/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/servlet/v3_0/Servlet3InitAdvice.java

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55

66
package io.opentelemetry.javaagent.instrumentation.servlet.v3_0;
77

8-
import static io.opentelemetry.javaagent.instrumentation.servlet.v3_0.Servlet3Singletons.SERVLET_MAPPING_RESOLVER_FACTORY;
8+
import static io.opentelemetry.javaagent.instrumentation.servlet.v3_0.Servlet3Singletons.SERVLET_MAPPING_RESOLVER;
99

1010
import javax.servlet.Servlet;
1111
import javax.servlet.ServletConfig;
@@ -20,7 +20,6 @@ public static void servletInit(
2020
if (servletConfig == null) {
2121
return;
2222
}
23-
SERVLET_MAPPING_RESOLVER_FACTORY.set(
24-
servlet, new Servlet3MappingResolverFactory(servletConfig));
23+
SERVLET_MAPPING_RESOLVER.set(servlet, new Servlet3MappingResolverFactory(servletConfig));
2524
}
2625
}

instrumentation/servlet/servlet-3.0/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/servlet/v3_0/Servlet3Singletons.java

Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -24,14 +24,6 @@
2424
public final class Servlet3Singletons {
2525
private static final String INSTRUMENTATION_NAME = "io.opentelemetry.servlet-3.0";
2626

27-
public static final VirtualField<Servlet, MappingResolver.Factory>
28-
SERVLET_MAPPING_RESOLVER_FACTORY =
29-
VirtualField.find(Servlet.class, MappingResolver.Factory.class);
30-
31-
public static final VirtualField<Filter, MappingResolver.Factory>
32-
FILTER_MAPPING_RESOLVER_FACTORY =
33-
VirtualField.find(Filter.class, MappingResolver.Factory.class);
34-
3527
private static final Instrumenter<
3628
ServletRequestContext<HttpServletRequest>, ServletResponseContext<HttpServletResponse>>
3729
INSTRUMENTER =
@@ -41,9 +33,9 @@ public final class Servlet3Singletons {
4133
private static final ServletHelper<HttpServletRequest, HttpServletResponse> HELPER =
4234
new ServletHelper<>(INSTRUMENTER, Servlet3Accessor.INSTANCE);
4335

44-
private static final VirtualField<Servlet, MappingResolver.Factory> SERVLET_MAPPING_RESOLVER =
36+
public static final VirtualField<Servlet, MappingResolver.Factory> SERVLET_MAPPING_RESOLVER =
4537
VirtualField.find(Servlet.class, MappingResolver.Factory.class);
46-
private static final VirtualField<Filter, MappingResolver.Factory> FILTER_MAPPING_RESOLVER =
38+
public static final VirtualField<Filter, MappingResolver.Factory> FILTER_MAPPING_RESOLVER =
4739
VirtualField.find(Filter.class, MappingResolver.Factory.class);
4840

4941
private static final Instrumenter<ClassAndMethod, Void> RESPONSE_INSTRUMENTER =

0 commit comments

Comments
 (0)