Skip to content

Commit 2587e98

Browse files
jaydelucajaydeluca
committed
remove kafka metric assertion
1 parent a87fd0e commit 2587e98

File tree

2 files changed

+262
-11
lines changed

2 files changed

+262
-11
lines changed

‎docs/instrumentation-list.yaml‎

Lines changed: 262 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8346,31 +8346,293 @@ libraries:
83468346
source_path: instrumentation/ktor/ktor-1.0
83478347
scope:
83488348
name: io.opentelemetry.ktor-1.0
8349+
schema_url: https://opentelemetry.io/schemas/1.37.0
83498350
target_versions:
83508351
library:
83518352
- io.ktor:ktor-server-core:[1.0.0,1.+)
8353+
telemetry:
8354+
- when: default
8355+
metrics:
8356+
- name: http.server.request.duration
8357+
description: Duration of HTTP server requests.
8358+
type: HISTOGRAM
8359+
unit: s
8360+
attributes:
8361+
- name: http.request.method
8362+
type: STRING
8363+
- name: http.response.status_code
8364+
type: LONG
8365+
- name: http.route
8366+
type: STRING
8367+
- name: network.protocol.version
8368+
type: STRING
8369+
- name: url.scheme
8370+
type: STRING
8371+
spans:
8372+
- span_kind: CONSUMER
8373+
attributes:
8374+
- name: client.address
8375+
type: STRING
8376+
- name: http.request.method
8377+
type: STRING
8378+
- name: http.response.status_code
8379+
type: LONG
8380+
- name: network.peer.address
8381+
type: STRING
8382+
- name: network.protocol.version
8383+
type: STRING
8384+
- name: server.address
8385+
type: STRING
8386+
- name: server.port
8387+
type: LONG
8388+
- name: url.path
8389+
type: STRING
8390+
- name: url.query
8391+
type: STRING
8392+
- name: url.scheme
8393+
type: STRING
8394+
- name: user_agent.original
8395+
type: STRING
8396+
- span_kind: SERVER
8397+
attributes:
8398+
- name: client.address
8399+
type: STRING
8400+
- name: error.type
8401+
type: STRING
8402+
- name: http.request.method
8403+
type: STRING
8404+
- name: http.request.method_original
8405+
type: STRING
8406+
- name: http.response.status_code
8407+
type: LONG
8408+
- name: http.route
8409+
type: STRING
8410+
- name: network.peer.address
8411+
type: STRING
8412+
- name: network.protocol.version
8413+
type: STRING
8414+
- name: server.address
8415+
type: STRING
8416+
- name: server.port
8417+
type: LONG
8418+
- name: url.path
8419+
type: STRING
8420+
- name: url.query
8421+
type: STRING
8422+
- name: url.scheme
8423+
type: STRING
8424+
- name: user_agent.original
8425+
type: STRING
83528426
- name: ktor-2.0
83538427
source_path: instrumentation/ktor/ktor-2.0
83548428
scope:
83558429
name: io.opentelemetry.ktor-2.0
8430+
schema_url: https://opentelemetry.io/schemas/1.37.0
83568431
target_versions:
83578432
javaagent:
83588433
- io.ktor:ktor-client-core:[2.0.0,3.0.0)
83598434
- io.ktor:ktor-server-core:[2.0.0,3.0.0)
83608435
library:
83618436
- io.ktor:ktor-client-core:[2.0.0,2.+)
83628437
- io.ktor:ktor-server-core:[2.0.0,2.+)
8438+
telemetry:
8439+
- when: default
8440+
metrics:
8441+
- name: http.client.request.duration
8442+
description: Duration of HTTP client requests.
8443+
type: HISTOGRAM
8444+
unit: s
8445+
attributes:
8446+
- name: http.request.method
8447+
type: STRING
8448+
- name: http.response.status_code
8449+
type: LONG
8450+
- name: network.protocol.version
8451+
type: STRING
8452+
- name: server.address
8453+
type: STRING
8454+
- name: server.port
8455+
type: LONG
8456+
- name: http.server.request.duration
8457+
description: Duration of HTTP server requests.
8458+
type: HISTOGRAM
8459+
unit: s
8460+
attributes:
8461+
- name: http.request.method
8462+
type: STRING
8463+
- name: http.response.status_code
8464+
type: LONG
8465+
- name: http.route
8466+
type: STRING
8467+
- name: network.protocol.version
8468+
type: STRING
8469+
- name: url.scheme
8470+
type: STRING
8471+
spans:
8472+
- span_kind: CLIENT
8473+
attributes:
8474+
- name: error.type
8475+
type: STRING
8476+
- name: http.request.method
8477+
type: STRING
8478+
- name: http.request.method_original
8479+
type: STRING
8480+
- name: http.request.resend_count
8481+
type: LONG
8482+
- name: http.response.status_code
8483+
type: LONG
8484+
- name: network.protocol.version
8485+
type: STRING
8486+
- name: server.address
8487+
type: STRING
8488+
- name: server.port
8489+
type: LONG
8490+
- name: url.full
8491+
type: STRING
8492+
- span_kind: CONSUMER
8493+
attributes:
8494+
- name: client.address
8495+
type: STRING
8496+
- name: http.request.method
8497+
type: STRING
8498+
- name: http.response.status_code
8499+
type: LONG
8500+
- name: network.protocol.version
8501+
type: STRING
8502+
- name: server.address
8503+
type: STRING
8504+
- name: server.port
8505+
type: LONG
8506+
- name: url.path
8507+
type: STRING
8508+
- name: url.query
8509+
type: STRING
8510+
- name: url.scheme
8511+
type: STRING
8512+
- name: user_agent.original
8513+
type: STRING
8514+
- span_kind: SERVER
8515+
attributes:
8516+
- name: client.address
8517+
type: STRING
8518+
- name: error.type
8519+
type: STRING
8520+
- name: http.request.method
8521+
type: STRING
8522+
- name: http.request.method_original
8523+
type: STRING
8524+
- name: http.response.status_code
8525+
type: LONG
8526+
- name: http.route
8527+
type: STRING
8528+
- name: network.protocol.version
8529+
type: STRING
8530+
- name: server.address
8531+
type: STRING
8532+
- name: server.port
8533+
type: LONG
8534+
- name: url.path
8535+
type: STRING
8536+
- name: url.query
8537+
type: STRING
8538+
- name: url.scheme
8539+
type: STRING
8540+
- name: user_agent.original
8541+
type: STRING
83638542
- name: ktor-3.0
83648543
source_path: instrumentation/ktor/ktor-3.0
83658544
scope:
83668545
name: io.opentelemetry.ktor-3.0
8546+
schema_url: https://opentelemetry.io/schemas/1.37.0
83678547
target_versions:
83688548
javaagent:
83698549
- io.ktor:ktor-server-core:[3.0.0,)
83708550
- io.ktor:ktor-client-core:[3.0.0,)
83718551
library:
83728552
- io.ktor:ktor-server-core:3.0.0
83738553
- io.ktor:ktor-client-core:3.0.0
8554+
telemetry:
8555+
- when: default
8556+
metrics:
8557+
- name: http.client.request.duration
8558+
description: Duration of HTTP client requests.
8559+
type: HISTOGRAM
8560+
unit: s
8561+
attributes:
8562+
- name: http.request.method
8563+
type: STRING
8564+
- name: http.response.status_code
8565+
type: LONG
8566+
- name: network.protocol.version
8567+
type: STRING
8568+
- name: server.address
8569+
type: STRING
8570+
- name: server.port
8571+
type: LONG
8572+
- name: http.server.request.duration
8573+
description: Duration of HTTP server requests.
8574+
type: HISTOGRAM
8575+
unit: s
8576+
attributes:
8577+
- name: http.request.method
8578+
type: STRING
8579+
- name: http.response.status_code
8580+
type: LONG
8581+
- name: http.route
8582+
type: STRING
8583+
- name: network.protocol.version
8584+
type: STRING
8585+
- name: url.scheme
8586+
type: STRING
8587+
spans:
8588+
- span_kind: CLIENT
8589+
attributes:
8590+
- name: error.type
8591+
type: STRING
8592+
- name: http.request.method
8593+
type: STRING
8594+
- name: http.request.method_original
8595+
type: STRING
8596+
- name: http.request.resend_count
8597+
type: LONG
8598+
- name: http.response.status_code
8599+
type: LONG
8600+
- name: network.protocol.version
8601+
type: STRING
8602+
- name: server.address
8603+
type: STRING
8604+
- name: server.port
8605+
type: LONG
8606+
- name: url.full
8607+
type: STRING
8608+
- span_kind: SERVER
8609+
attributes:
8610+
- name: client.address
8611+
type: STRING
8612+
- name: error.type
8613+
type: STRING
8614+
- name: http.request.method
8615+
type: STRING
8616+
- name: http.request.method_original
8617+
type: STRING
8618+
- name: http.response.status_code
8619+
type: LONG
8620+
- name: http.route
8621+
type: STRING
8622+
- name: network.protocol.version
8623+
type: STRING
8624+
- name: server.address
8625+
type: STRING
8626+
- name: server.port
8627+
type: LONG
8628+
- name: url.path
8629+
type: STRING
8630+
- name: url.query
8631+
type: STRING
8632+
- name: url.scheme
8633+
type: STRING
8634+
- name: user_agent.original
8635+
type: STRING
83748636
kubernetes:
83758637
- name: kubernetes-client-7.0
83768638
source_path: instrumentation/kubernetes-client-7.0

‎instrumentation/kafka/kafka-clients/kafka-clients-0.11/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/kafkaclients/v0_11/KafkaClientDefaultTest.java‎

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,6 @@
2626
import org.apache.kafka.clients.consumer.ConsumerRecord;
2727
import org.apache.kafka.clients.consumer.ConsumerRecords;
2828
import org.apache.kafka.clients.producer.ProducerRecord;
29-
import org.assertj.core.api.AbstractIterableAssert;
3029
import org.junit.jupiter.api.DisplayName;
3130
import org.junit.jupiter.api.Test;
3231
import org.junit.jupiter.api.extension.RegisterExtension;
@@ -35,9 +34,6 @@
3534

3635
class KafkaClientDefaultTest extends KafkaClientPropagationBaseTest {
3736

38-
private static final boolean testLatestDeps =
39-
Boolean.parseBoolean(System.getProperty("testLatestDeps", "true"));
40-
4137
@RegisterExtension
4238
static final InstrumentationExtension testing = AgentInstrumentationExtension.create();
4339

@@ -114,13 +110,6 @@ void testKafkaProducerAndConsumerSpan(boolean testHeaders) throws Exception {
114110
.hasAttributesSatisfyingExactly(
115111
processAttributes("10", greeting, testHeaders, false)),
116112
span -> span.hasName("processing").hasParent(trace.getSpan(1))));
117-
118-
if (testLatestDeps) {
119-
testing.waitAndAssertMetrics(
120-
"io.opentelemetry.kafka-clients-0.11",
121-
"kafka.producer.record_send_total",
122-
AbstractIterableAssert::isNotEmpty);
123-
}
124113
}
125114

126115
@DisplayName("test pass through tombstone")

0 commit comments

Comments
 (0)