Skip to content

Commit 26df612

Browse files
committed
sling: checkstyle fixes
1 parent e2e0723 commit 26df612

File tree

1 file changed

+2
-12
lines changed
  • instrumentation/sling/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/sling

1 file changed

+2
-12
lines changed

instrumentation/sling/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/sling/SlingTest.java

Lines changed: 2 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -95,11 +95,6 @@ void basic() throws Exception {
9595

9696
List<List<SpanData>> traces = testing.waitForTraces(1);
9797

98-
traces.forEach(
99-
trace -> {
100-
System.out.println("!!!Trace: " + trace);
101-
});
102-
10398
List<SpanData> mainTrace = traces.get(0);
10499
assertThat(mainTrace).hasSize(3);
105100
// top-level trace
@@ -141,8 +136,7 @@ protected Void setupServer() throws Exception {
141136
Bootstrap b = new Bootstrap(cfg, log);
142137
b.runWithException();
143138
} catch (Exception e) {
144-
e.printStackTrace(System.err);
145-
// throw new RuntimeException(e);
139+
log.error("Failed to start Sling server, test will time out and fail.", e);
146140
}
147141
});
148142

@@ -159,8 +153,6 @@ protected Void setupServer() throws Exception {
159153
}
160154
});
161155

162-
System.err.println("Sling server bound to " + address);
163-
164156
Awaitility.await()
165157
.atMost(Duration.ofMinutes(4))
166158
.pollInterval(Duration.ofMillis(500))
@@ -176,14 +168,12 @@ protected Void setupServer() throws Exception {
176168
}
177169
});
178170

179-
System.err.println("Sling server serving requests at " + address);
180-
181171
return null;
182172
}
183173

184174
@Override
185175
protected void stopServer(Void unused) throws Exception {
186-
System.err.println("Stopping server is not implemented.");
176+
log.warn("Stopping Sling server is not implemented");
187177
}
188178

189179
@Override

0 commit comments

Comments
 (0)