Skip to content

Commit 27fdc38

Browse files
committed
Add server.address and server.port for lettuce
1 parent 105c7ca commit 27fdc38

File tree

4 files changed

+10
-15
lines changed

4 files changed

+10
-15
lines changed

instrumentation/lettuce/lettuce-4.0/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/lettuce/v4_0/LettuceAsyncCommandsInstrumentation.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ public static AdviceScope onEnter(
7070
@Advice.Argument(0) RedisCommand<?, ?, ?> command) {
7171

7272
StatefulConnection<?, ?> connection = asyncCommands.getConnection();
73-
RedisURI redisUri = CONNECTION_URI.get(connection);
73+
RedisURI redisUri = connection != null ? CONNECTION_URI.get(connection) : null;
7474

7575
if (redisUri != null) {
7676
COMMAND_CONNECTION_INFO.set(command, redisUri);

instrumentation/lettuce/lettuce-4.0/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/lettuce/v4_0/LettuceSingletons.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,8 +36,8 @@ public final class LettuceSingletons {
3636
VirtualField.find(AsyncCommand.class, Context.class);
3737
public static final VirtualField<StatefulConnection<?, ?>, RedisURI> CONNECTION_URI =
3838
VirtualField.find(StatefulConnection.class, RedisURI.class);
39-
public static final VirtualField<RedisCommand<?, ?, ?>, RedisURI>
40-
COMMAND_CONNECTION_INFO = VirtualField.find(RedisCommand.class, RedisURI.class);
39+
public static final VirtualField<RedisCommand<?, ?, ?>, RedisURI> COMMAND_CONNECTION_INFO =
40+
VirtualField.find(RedisCommand.class, RedisURI.class);
4141

4242
static {
4343
LettuceDbAttributesGetter dbAttributesGetter = new LettuceDbAttributesGetter();

instrumentation/lettuce/lettuce-5.0/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/lettuce/v5_0/LettuceSingletons.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -36,8 +36,8 @@ public final class LettuceSingletons {
3636
VirtualField.find(AsyncCommand.class, Context.class);
3737
public static final VirtualField<StatefulConnection<?, ?>, RedisURI> CONNECTION_URI =
3838
VirtualField.find(StatefulConnection.class, RedisURI.class);
39-
public static final VirtualField<RedisCommand<?, ?, ?>, RedisURI>
40-
COMMAND_CONNECTION_INFO = VirtualField.find(RedisCommand.class, RedisURI.class);
39+
public static final VirtualField<RedisCommand<?, ?, ?>, RedisURI> COMMAND_CONNECTION_INFO =
40+
VirtualField.find(RedisCommand.class, RedisURI.class);
4141

4242
static {
4343
LettuceDbAttributesGetter dbAttributesGetter = new LettuceDbAttributesGetter();

instrumentation/lettuce/lettuce-5.0/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/lettuce/v5_0/rx/LettuceReactiveCommandsInstrumentation.java

Lines changed: 5 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@
1616
import static net.bytebuddy.matcher.ElementMatchers.returns;
1717
import static net.bytebuddy.matcher.ElementMatchers.takesArgument;
1818

19+
import io.lettuce.core.AbstractRedisReactiveCommands;
1920
import io.lettuce.core.RedisURI;
2021
import io.lettuce.core.api.StatefulConnection;
2122
import io.lettuce.core.protocol.RedisCommand;
@@ -64,14 +65,11 @@ public static <K, V, T> RedisCommand<K, V, T> extractCommandName(
6465
@Advice.Argument(0) Supplier<RedisCommand<K, V, T>> supplier) {
6566
RedisCommand<K, V, T> command = supplier.get();
6667

67-
// Get connection from reactive commands object
6868
StatefulConnection<?, ?> connection = null;
69-
if (reactiveCommands instanceof io.lettuce.core.AbstractRedisReactiveCommands) {
70-
connection = ((io.lettuce.core.AbstractRedisReactiveCommands<?, ?>) reactiveCommands).getConnection();
69+
if (reactiveCommands instanceof AbstractRedisReactiveCommands) {
70+
connection = ((AbstractRedisReactiveCommands<?, ?>) reactiveCommands).getConnection();
7171
}
7272

73-
// Set connection info BEFORE creating the span (similar to
74-
// LettuceAsyncCommandsInstrumentation)
7573
RedisURI redisUri = connection != null ? CONNECTION_URI.get(connection) : null;
7674

7775
if (redisUri != null) {
@@ -109,14 +107,11 @@ public static <K, V, T> RedisCommand<K, V, T> extractCommandName(
109107
@Advice.Argument(0) Supplier<RedisCommand<K, V, T>> supplier) {
110108
RedisCommand<K, V, T> command = supplier.get();
111109

112-
// Get connection from reactive commands object
113110
StatefulConnection<?, ?> connection = null;
114-
if (reactiveCommands instanceof io.lettuce.core.AbstractRedisReactiveCommands) {
115-
connection = ((io.lettuce.core.AbstractRedisReactiveCommands<?, ?>) reactiveCommands).getConnection();
111+
if (reactiveCommands instanceof AbstractRedisReactiveCommands) {
112+
connection = ((AbstractRedisReactiveCommands<?, ?>) reactiveCommands).getConnection();
116113
}
117114

118-
// Set connection info BEFORE creating the span (similar to
119-
// LettuceAsyncCommandsInstrumentation)
120115
RedisURI redisUri = connection != null ? CONNECTION_URI.get(connection) : null;
121116

122117
if (redisUri != null) {

0 commit comments

Comments
 (0)