Skip to content

Commit 29ecd0d

Browse files
committed
sync
1 parent a98a3c9 commit 29ecd0d

File tree

3 files changed

+27
-0
lines changed

3 files changed

+27
-0
lines changed

instrumentation/jdbc/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/jdbc/PreparedStatementInstrumentation.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -60,6 +60,7 @@ public void transform(TypeTransformer transformer) {
6060
transformer.applyAdviceToMethod(
6161
namedOneOf(
6262
"setBoolean",
63+
"setByte",
6364
"setShort",
6465
"setInt",
6566
"setLong",

instrumentation/jdbc/library/src/main/java/io/opentelemetry/instrumentation/jdbc/internal/OpenTelemetryPreparedStatement.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -107,6 +107,7 @@ public void setBoolean(int parameterIndex, boolean x) throws SQLException {
107107
@Override
108108
public void setByte(int parameterIndex, byte x) throws SQLException {
109109
delegate.setByte(parameterIndex, x);
110+
putParameter(parameterIndex, String.valueOf(x));
110111
}
111112

112113
@Override

instrumentation/jdbc/testing/src/main/java/io/opentelemetry/instrumentation/jdbc/testing/AbstractPreparedStatementParametersTest.java

Lines changed: 25 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -134,6 +134,31 @@ void testBooleanPreparedStatementParameter(
134134
"true");
135135
}
136136

137+
@ParameterizedTest
138+
@MethodSource("preparedStatementStream")
139+
void testBytePreparedStatementParameter(
140+
String system,
141+
Connection connection,
142+
String username,
143+
String query,
144+
String sanitizedQuery,
145+
String spanName,
146+
String url,
147+
String table)
148+
throws SQLException {
149+
test(
150+
system,
151+
connection,
152+
username,
153+
query,
154+
sanitizedQuery,
155+
spanName,
156+
url,
157+
table,
158+
statement -> statement.setByte(1, (byte) 42),
159+
"42");
160+
}
161+
137162
@ParameterizedTest
138163
@MethodSource("preparedStatementStream")
139164
void testShortPreparedStatementParameter(

0 commit comments

Comments
 (0)