Skip to content

Commit 2da2a40

Browse files
committed
address review comment
1 parent 4dfed53 commit 2da2a40

File tree

1 file changed

+3
-2
lines changed
  • instrumentation/vertx/vertx-http-client/vertx-http-client-4.0/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/vertx/v4_0/client

1 file changed

+3
-2
lines changed

instrumentation/vertx/vertx-http-client/vertx-http-client-4.0/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/vertx/v4_0/client/VertxHttpClientTest.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,8 @@
55

66
package io.opentelemetry.javaagent.instrumentation.vertx.v4_0.client;
77

8+
import static java.util.Collections.emptySet;
9+
810
import io.opentelemetry.api.common.AttributeKey;
911
import io.opentelemetry.instrumentation.testing.junit.InstrumentationExtension;
1012
import io.opentelemetry.instrumentation.testing.junit.http.AbstractHttpClientTest;
@@ -20,7 +22,6 @@
2022
import io.vertx.core.http.HttpMethod;
2123
import io.vertx.core.http.RequestOptions;
2224
import java.net.URI;
23-
import java.util.Collections;
2425
import java.util.Map;
2526
import java.util.Set;
2627
import java.util.concurrent.CompletableFuture;
@@ -105,7 +106,7 @@ private static Set<AttributeKey<?>> getHttpAttributes(URI uri) {
105106
String uriString = uri.toString();
106107
// http://localhost:61/ => unopened port, http://192.0.2.1/ => non routable address
107108
if ("http://localhost:61/".equals(uriString) || "http://192.0.2.1/".equals(uriString)) {
108-
return Collections.emptySet();
109+
return emptySet();
109110
}
110111
return HttpClientTestOptions.DEFAULT_HTTP_ATTRIBUTES;
111112
}

0 commit comments

Comments
 (0)