Addressed code review feedback:

1. Used constant from semconv.
2. Moved extraction code out of the experimental module.

Author: lukeina2z

instrumentation/aws-sdk/aws-sdk-2.2/library/src/main/java/io/opentelemetry/instrumentation/awssdk/v2_2/internal/AwsExperimentalAttributes.java

@@ -5,12 +5,7 @@
 
 package io.opentelemetry.instrumentation.awssdk.v2_2.internal;
 
-import static io.opentelemetry.instrumentation.awssdk.v2_2.internal.AwsExperimentalAttributes.AWS_BUCKET_NAME;
-import static io.opentelemetry.instrumentation.awssdk.v2_2.internal.AwsExperimentalAttributes.AWS_QUEUE_NAME;
-import static io.opentelemetry.instrumentation.awssdk.v2_2.internal.AwsExperimentalAttributes.AWS_QUEUE_URL;
-import static io.opentelemetry.instrumentation.awssdk.v2_2.internal.AwsExperimentalAttributes.AWS_SECRET_ARN;
-import static io.opentelemetry.instrumentation.awssdk.v2_2.internal.AwsExperimentalAttributes.AWS_STREAM_NAME;
-import static io.opentelemetry.instrumentation.awssdk.v2_2.internal.AwsExperimentalAttributes.AWS_TABLE_NAME;
+import static io.opentelemetry.api.common.AttributeKey.stringKey;
 import static io.opentelemetry.instrumentation.awssdk.v2_2.internal.FieldMapping.request;
 import static io.opentelemetry.instrumentation.awssdk.v2_2.internal.FieldMapping.response;
 
@@ -20,12 +15,12 @@
 import java.util.Map;
 
 enum AwsSdkRequestType {
-  S3(request(AWS_BUCKET_NAME.getKey(), "Bucket")),
-  SQS(request(AWS_QUEUE_URL.getKey(), "QueueUrl"), request(AWS_QUEUE_NAME.getKey(), "QueueName")),
-  KINESIS(request(AWS_STREAM_NAME.getKey(), "StreamName")),
-  DYNAMODB(request(AWS_TABLE_NAME.getKey(), "TableName")),
+  S3(request("aws.bucket.name", "Bucket")),
+  SQS(request("aws.queue.url", "QueueUrl"), request("aws.queue.name", "QueueName")),
+  KINESIS(request("aws.stream.name", "StreamName")),
+  DYNAMODB(request("aws.table.name", "TableName")),
   BEDROCK_RUNTIME(),
-  SECRETSMANAGER(response(AWS_SECRET_ARN.getKey(), "ARN")),
+  SECRETSMANAGER(response(AttributeKeys.AWS_SECRETSMANAGER_SECRET_ARN.getKey(), "ARN")),
   SNS(
       /*
        * Only one of TopicArn and TargetArn are permitted on an SNS request.
@@ -46,6 +41,10 @@ List<FieldMapping> fields(FieldMapping.Type type) {
   }
 
   private static class AttributeKeys {
+    // Copied from AwsIncubatingAttributes
+    static final AttributeKey<String> AWS_SECRETSMANAGER_SECRET_ARN =
+        stringKey("aws.secretsmanager.secret.arn");
+
     // copied from MessagingIncubatingAttributes
     static final AttributeKey<String> MESSAGING_DESTINATION_NAME =
         AttributeKey.stringKey("messaging.destination.name");

instrumentation/aws-sdk/aws-sdk-2.2/library/src/main/java/io/opentelemetry/instrumentation/awssdk/v2_2/internal/AwsSdkRequestType.java

@@ -27,6 +27,7 @@
 import static org.assertj.core.api.Assertions.assertThatThrownBy;
 import static org.assertj.core.api.Assertions.catchThrowable;
 
+import io.opentelemetry.api.common.AttributeKey;
 import io.opentelemetry.api.trace.SpanKind;
 import io.opentelemetry.context.Context;
 import io.opentelemetry.sdk.testing.assertj.AttributeAssertion;
@@ -106,6 +107,10 @@ public abstract class AbstractAws2ClientTest extends AbstractAws2ClientCoreTest
   // prefix the hostname with the bucket name as label.
   private final URI clientUri = URI.create("http://localhost:" + server.httpPort());
 
+  // Copied from AwsIncubatingAttributes. Not available in current version of semconv.
+  private static final AttributeKey<String> AWS_SECRETSMANAGER_SECRET_ARN =
+      stringKey("aws.secretsmanager.secret.arn");
+
   private static final String ec2BodyContent =
       "<AllocateAddressResponse xmlns=\"http://ec2.amazonaws.com/doc/2016-11-15/\">"
           + " <requestId>59dbff89-35bd-4eac-99ed-be587EXAMPLE</requestId>"
@@ -235,7 +240,7 @@ private void clientAssertions(
     if (service.equals("SecretsManager")) {
       attributes.add(
           equalTo(
-              stringKey("aws.secretsmanager.secret.arn"),
+              stringKey(AWS_SECRETSMANAGER_SECRET_ARN.getKey()),
               "arn:aws:secretsmanager:us-east-1:123456789012:secret:MySecretFromCLI-sNkBwD"));
     }