pr review

Author: zeitlinger

instrumentation/servlet/servlet-5.0/jetty11-testing/build.gradle.kts

@@ -8,13 +8,13 @@ dependencies {
   testInstrumentation(project(":instrumentation:jetty:jetty-11.0:javaagent"))
   testImplementation(project(":instrumentation:servlet:servlet-5.0:testing"))
 
-  // Jetty 11 requires Java 11
   testLibrary("org.eclipse.jetty:jetty-server:11.0.0")
   testLibrary("org.eclipse.jetty:jetty-servlet:11.0.0")
 
-  latestDepTestLibrary("org.eclipse.jetty:jetty-server:11.+")
+  latestDepTestLibrary("org.eclipse.jetty:jetty-server:11.+") // see jetty-12-testing module
 }
 
+// Jetty 11 requires Java 11
 otelJava {
   minJavaVersionSupported.set(JavaVersion.VERSION_11)
 }

instrumentation/servlet/servlet-5.0/tomcat-testing/src/test/java/io/opentelemetry/javaagent/instrumentation/servlet/v5_0/tomcat/mapping/TomcatServlet5MappingTest.java

@@ -13,10 +13,7 @@
 import org.apache.catalina.Context;
 import org.apache.catalina.LifecycleException;
 import org.apache.catalina.startup.Tomcat;
-import org.junit.jupiter.api.condition.EnabledForJreRange;
-import org.junit.jupiter.api.condition.JRE;
 
-@EnabledForJreRange(min = JRE.JAVA_11)
 class TomcatServlet5MappingTest extends AbstractServlet5MappingTest<Tomcat, Context> {
   @Override
   protected Tomcat setupServer() throws Exception {