Skip to content

Commit 327754f

Browse files
committed
manual scala
1 parent cc11c9b commit 327754f

File tree

1 file changed

+15
-24
lines changed
  • instrumentation/jdbc/javaagent/src/test/scala/io/opentelemetry/javaagent/instrumentation/scalaexecutors

1 file changed

+15
-24
lines changed

instrumentation/jdbc/javaagent/src/test/scala/io/opentelemetry/javaagent/instrumentation/scalaexecutors/SlickTest.scala

Lines changed: 15 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -6,24 +6,21 @@
66
package io.opentelemetry.javaagent.instrumentation.scalaexecutors
77

88
import io.opentelemetry.api.trace.{SpanKind, Tracer}
9-
import io.opentelemetry.instrumentation.testing.junit.{
10-
AgentInstrumentationExtension,
11-
InstrumentationExtension
12-
}
9+
import io.opentelemetry.instrumentation.api.internal.SemconvStability.emitStableDatabaseSemconv
10+
import io.opentelemetry.instrumentation.testing.junit.db.SemconvStabilityUtil.maybeStable
11+
import io.opentelemetry.instrumentation.testing.junit.{AgentInstrumentationExtension, InstrumentationExtension}
1312
import io.opentelemetry.javaagent.testing.common.Java8BytecodeBridge
14-
import io.opentelemetry.sdk.testing.assertj.{SpanDataAssert, TraceAssert}
1513
import io.opentelemetry.sdk.testing.assertj.OpenTelemetryAssertions.equalTo
16-
import io.opentelemetry.semconv.incubating.DbIncubatingAttributes
17-
import io.opentelemetry.semconv.incubating.DbIncubatingAttributes.DbSystemIncubatingValues
18-
19-
import java.util.function.Consumer
14+
import io.opentelemetry.sdk.testing.assertj.{SpanDataAssert, TraceAssert}
15+
import io.opentelemetry.semconv.incubating.DbIncubatingAttributes._
2016
import org.assertj.core.api.Assertions.assertThat
21-
import org.junit.jupiter.api.{Test, TestInstance}
2217
import org.junit.jupiter.api.extension.RegisterExtension
18+
import org.junit.jupiter.api.{Test, TestInstance}
19+
import slick.jdbc.H2Profile.api._
2320

24-
import scala.concurrent.{Await, Future}
21+
import java.util.function.Consumer
2522
import scala.concurrent.duration.Duration
26-
import slick.jdbc.H2Profile.api._
23+
import scala.concurrent.{Await, Future}
2724

2825
@TestInstance(TestInstance.Lifecycle.PER_CLASS)
2926
class SlickTest {
@@ -81,18 +78,12 @@ class SlickTest {
8178
.hasKind(SpanKind.CLIENT)
8279
.hasParent(trace.getSpan(0))
8380
.hasAttributesSatisfyingExactly(
84-
equalTo(
85-
DbIncubatingAttributes.DB_SYSTEM,
86-
DbSystemIncubatingValues.H2
87-
),
88-
equalTo(DbIncubatingAttributes.DB_NAME, Db),
89-
equalTo(DbIncubatingAttributes.DB_USER, Username),
90-
equalTo(
91-
DbIncubatingAttributes.DB_CONNECTION_STRING,
92-
"h2:mem:"
93-
),
94-
equalTo(DbIncubatingAttributes.DB_STATEMENT, "SELECT ?"),
95-
equalTo(DbIncubatingAttributes.DB_OPERATION, "SELECT")
81+
equalTo(DB_SYSTEM, DbSystemIncubatingValues.H2),
82+
equalTo(maybeStable(DB_NAME), Db),
83+
equalTo(DB_USER, if (emitStableDatabaseSemconv()) null else Username),
84+
equalTo(DB_CONNECTION_STRING, if (emitStableDatabaseSemconv()) null else "h2:mem:"),
85+
equalTo(maybeStable(DB_STATEMENT), "SELECT ?"),
86+
equalTo(maybeStable(DB_OPERATION), "SELECT")
9687
)
9788
}
9889
)

0 commit comments

Comments
 (0)