make kotlinx-coroutines indy-ready (#15010)

Author: SylvainJuge

instrumentation/kotlinx-coroutines/kotlinx-coroutines-1.0/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/kotlinxcoroutines/KotlinCoroutineDispatcherInstrumentation.java

@@ -13,6 +13,8 @@
 import io.opentelemetry.javaagent.extension.instrumentation.TypeInstrumentation;
 import io.opentelemetry.javaagent.extension.instrumentation.TypeTransformer;
 import net.bytebuddy.asm.Advice;
+import net.bytebuddy.asm.Advice.AssignReturned;
+import net.bytebuddy.asm.Advice.AssignReturned.ToArguments.ToArgument;
 import net.bytebuddy.description.type.TypeDescription;
 import net.bytebuddy.matcher.ElementMatcher;
 
@@ -38,11 +40,10 @@ public void transform(TypeTransformer transformer) {
   @SuppressWarnings("unused")
   public static class StopContextPropagationAdvice {
 
+    @AssignReturned.ToArguments(@ToArgument(1))
     @Advice.OnMethodEnter
-    public static void enter(@Advice.Argument(value = 1, readOnly = false) Runnable runnable) {
-      if (runnable != null) {
-        runnable = RunnableWrapper.stopPropagation(runnable);
-      }
+    public static Runnable enter(@Advice.Argument(1) Runnable runnable) {
+      return runnable == null ? null : RunnableWrapper.stopPropagation(runnable);
     }
   }
 }

instrumentation/kotlinx-coroutines/kotlinx-coroutines-1.0/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/kotlinxcoroutines/KotlinCoroutinesInstrumentation.java

@@ -12,6 +12,8 @@
 import io.opentelemetry.javaagent.extension.instrumentation.TypeTransformer;
 import kotlin.coroutines.CoroutineContext;
 import net.bytebuddy.asm.Advice;
+import net.bytebuddy.asm.Advice.AssignReturned;
+import net.bytebuddy.asm.Advice.AssignReturned.ToArguments.ToArgument;
 import net.bytebuddy.description.type.TypeDescription;
 import net.bytebuddy.matcher.ElementMatcher;
 
@@ -33,13 +35,12 @@ public void transform(TypeTransformer transformer) {
   @SuppressWarnings("unused")
   public static class ContextAdvice {
 
+    @AssignReturned.ToArguments(@ToArgument(1))
     @Advice.OnMethodEnter
-    public static void enter(
-        @Advice.Argument(value = 1, readOnly = false) CoroutineContext coroutineContext) {
-      if (coroutineContext != null) {
-        coroutineContext =
-            KotlinCoroutinesInstrumentationHelper.addOpenTelemetryContext(coroutineContext);
-      }
+    public static CoroutineContext enter(@Advice.Argument(1) CoroutineContext coroutineContext) {
+      return coroutineContext == null
+          ? null
+          : KotlinCoroutinesInstrumentationHelper.addOpenTelemetryContext(coroutineContext);
     }
   }
 }

instrumentation/kotlinx-coroutines/kotlinx-coroutines-1.0/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/kotlinxcoroutines/KotlinCoroutinesInstrumentationModule.java

@@ -37,4 +37,9 @@ public List<TypeInstrumentation> typeInstrumentations() {
     return asList(
         new KotlinCoroutinesInstrumentation(), new KotlinCoroutineDispatcherInstrumentation());
   }
+
+  @Override
+  public boolean isIndyReady() {
+    return true;
+  }
 }

instrumentation/kotlinx-coroutines/kotlinx-coroutines-1.0/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/kotlinxcoroutines/instrumentationannotations/AnnotationInstrumentationModule.java

@@ -61,4 +61,9 @@ public void injectClasses(ClassInjector injector) {
             "io.opentelemetry.javaagent.instrumentation.kotlinxcoroutines.instrumentationannotations.AnnotationInstrumentationHelper")
         .inject(InjectionMode.CLASS_ONLY);
   }
+
+  @Override
+  public boolean isIndyReady() {
+    return true;
+  }
 }