Skip to content

Commit 3cdcb2b

Browse files
authored
Simplify some route getters (#9316)
1 parent 9f3ad5e commit 3cdcb2b

File tree

7 files changed

+7
-11
lines changed
  • instrumentation
    • armeria-1.3/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/armeria/v1_3
    • finatra-2.9/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/finatra
    • ratpack/ratpack-1.4/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/ratpack
    • restlet
      • restlet-1.1/library/src/main/java/io/opentelemetry/instrumentation/restlet/v1_1
      • restlet-2.0/library/src/main/java/io/opentelemetry/instrumentation/restlet/v2_0
    • spark-2.3/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/sparkjava
    • vaadin-14.2/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/vaadin

7 files changed

+7
-11
lines changed

instrumentation/armeria-1.3/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/armeria/v1_3/ServerDecorator.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,8 +34,7 @@ public HttpResponse serve(ServiceRequestContext ctx, HttpRequest req) throws Exc
3434

3535
Context otelContext = Context.current();
3636

37-
HttpServerRoute.update(
38-
otelContext, HttpServerRouteSource.SERVER, (context, name) -> name, matchedRoute);
37+
HttpServerRoute.update(otelContext, HttpServerRouteSource.SERVER, matchedRoute);
3938

4039
try {
4140
return unwrap().serve(ctx, req);

instrumentation/finatra-2.9/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/finatra/FinatraSingletons.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,8 +34,7 @@ public static Instrumenter<Class<?>, Void> instrumenter() {
3434
}
3535

3636
public static void updateServerSpanName(Context context, RouteInfo routeInfo) {
37-
HttpServerRoute.update(
38-
context, HttpServerRouteSource.CONTROLLER, (c, route) -> route.path(), routeInfo);
37+
HttpServerRoute.update(context, HttpServerRouteSource.CONTROLLER, routeInfo.path());
3938
}
4039

4140
private FinatraSingletons() {}

instrumentation/ratpack/ratpack-1.4/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/ratpack/RatpackSingletons.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -41,8 +41,7 @@ public static String updateServerSpanName(
4141
}
4242

4343
// update the netty server span name; FILTER is probably the best match for ratpack Handlers
44-
HttpServerRoute.update(
45-
otelContext, HttpServerRouteSource.SERVER_FILTER, (context, name) -> name, matchedRoute);
44+
HttpServerRoute.update(otelContext, HttpServerRouteSource.SERVER_FILTER, matchedRoute);
4645
return matchedRoute;
4746
}
4847

instrumentation/restlet/restlet-1.1/library/src/main/java/io/opentelemetry/instrumentation/restlet/v1_1/TracingFilter.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ public int doHandle(Request request, Response response) {
3838
scope = context.makeCurrent();
3939
}
4040

41-
HttpServerRoute.update(context, CONTROLLER, (ctx, s) -> s, path);
41+
HttpServerRoute.update(context, CONTROLLER, path);
4242

4343
Throwable statusThrowable = null;
4444
try {

instrumentation/restlet/restlet-2.0/library/src/main/java/io/opentelemetry/instrumentation/restlet/v2_0/TracingFilter.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ public int doHandle(Request request, Response response) {
3939
scope = context.makeCurrent();
4040
}
4141

42-
HttpServerRoute.update(context, CONTROLLER, (ctx, s) -> s, path);
42+
HttpServerRoute.update(context, CONTROLLER, path);
4343

4444
Throwable statusThrowable = null;
4545
try {

instrumentation/spark-2.3/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/sparkjava/SparkRouteUpdater.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,7 @@ public final class SparkRouteUpdater {
1616
public static void updateHttpRoute(@Nullable RouteMatch routeMatch) {
1717
if (routeMatch != null) {
1818
Context context = Context.current();
19-
HttpServerRoute.update(
20-
context, HttpServerRouteSource.CONTROLLER, (c, r) -> r.getMatchUri(), routeMatch);
19+
HttpServerRoute.update(context, HttpServerRouteSource.CONTROLLER, routeMatch.getMatchUri());
2120
}
2221
}
2322

instrumentation/vaadin-14.2/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/vaadin/VaadinHelper.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,7 @@ public void updateServerSpanName(Location location) {
110110
HttpServerRoute.update(
111111
context,
112112
HttpServerRouteSource.NESTED_CONTROLLER,
113-
(c, loc) -> ServletContextPath.prepend(c, getSpanNameForLocation(loc)),
113+
(ctx, loc) -> ServletContextPath.prepend(ctx, getSpanNameForLocation(loc)),
114114
location);
115115
}
116116

0 commit comments

Comments
 (0)