create method

Author: zeitlinger

javaagent-extension-api/src/main/java/io/opentelemetry/javaagent/extension/AgentListener.java

@@ -7,6 +7,7 @@
 
 import io.opentelemetry.api.incubator.config.ConfigProvider;
 import io.opentelemetry.api.incubator.config.DeclarativeConfigProperties;
+import io.opentelemetry.instrumentation.sdk.DeclarativeConfigPropertiesBridge;
 import io.opentelemetry.sdk.autoconfigure.AutoConfiguredOpenTelemetrySdk;
 import io.opentelemetry.sdk.autoconfigure.internal.AutoConfigureUtil;
 import io.opentelemetry.sdk.autoconfigure.spi.ConfigProperties;
@@ -44,7 +45,7 @@ static ConfigProperties resolveConfigProperties(
       DeclarativeConfigProperties instrumentationConfig = configProvider.getInstrumentationConfig();
 
       if (instrumentationConfig != null) {
-        return new DeclarativeConfigPropertiesBridge(instrumentationConfig);
+        return DeclarativeConfigPropertiesBridge.create(instrumentationConfig);
       }
     }
     // Should never happen

sdk-bridge/src/main/java/io/opentelemetry/instrumentation/sdk/DeclarativeConfigPropertiesBridge.java

@@ -52,10 +52,15 @@ public final class DeclarativeConfigPropertiesBridge implements ConfigProperties
   // The node at .instrumentation.java
   private final DeclarativeConfigProperties instrumentationJavaNode;
 
-  public DeclarativeConfigPropertiesBridge(DeclarativeConfigProperties instrumentationNode) {
+  private DeclarativeConfigPropertiesBridge(DeclarativeConfigProperties instrumentationNode) {
     instrumentationJavaNode = instrumentationNode.getStructured("java", DeclarativeConfigProperties.empty());
   }
 
+  public static DeclarativeConfigPropertiesBridge create(
+      DeclarativeConfigProperties instrumentationNode) {
+    return new DeclarativeConfigPropertiesBridge(instrumentationNode);
+  }
+
   @Nullable
   @Override
   public String getString(String propertyName) {

sdk-bridge/src/test/java/io/opentelemetry/instrumentation/sdk/DeclarativeConfigPropertiesBridgeTest.java

@@ -56,15 +56,15 @@ void setup() {
             new ByteArrayInputStream(YAML.getBytes(StandardCharsets.UTF_8)));
     SdkConfigProvider configProvider = SdkConfigProvider.create(model);
     bridge =
-        new DeclarativeConfigPropertiesBridge(
+        DeclarativeConfigPropertiesBridge.create(
             Objects.requireNonNull(configProvider.getInstrumentationConfig()));
 
     OpenTelemetryConfigurationModel emptyModel =
         new OpenTelemetryConfigurationModel()
             .withAdditionalProperty("instrumentation/development", new InstrumentationModel());
     SdkConfigProvider emptyConfigProvider = SdkConfigProvider.create(emptyModel);
     emptyBridge =
-        new DeclarativeConfigPropertiesBridge(
+        DeclarativeConfigPropertiesBridge.create(
             Objects.requireNonNull(emptyConfigProvider.getInstrumentationConfig()));
   }