Simplify Java agent instrumentation

Author: trask

instrumentation/java-util-logging/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/jul/JavaUtilLoggingHelper.java

@@ -85,13 +85,8 @@ private static void mapLogRecord(LogRecordBuilder builder, LogRecord logRecord)
     // throwable
     Throwable throwable = logRecord.getThrown();
     if (throwable != null) {
-      // TODO (trask) extract method for recording exception into
-      // io.opentelemetry:opentelemetry-api
-      attributes.put(ExceptionAttributes.EXCEPTION_TYPE, throwable.getClass().getName());
-      attributes.put(ExceptionAttributes.EXCEPTION_MESSAGE, throwable.getMessage());
-      StringWriter writer = new StringWriter();
-      throwable.printStackTrace(new PrintWriter(writer));
-      attributes.put(ExceptionAttributes.EXCEPTION_STACKTRACE, writer.toString());
+      // this cast is safe within java agent instrumentation
+      ((ExtendedLogRecordBuilder) builder).setException(throwable);
     }
 
     if (captureExperimentalAttributes) {

instrumentation/jboss-logmanager/jboss-logmanager-appender-1.1/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/jbosslogmanager/appender/v1_1/LoggingEventMapper.java

@@ -82,15 +82,8 @@ public void capture(Logger logger, ExtLogRecord record) {
 
     Throwable throwable = record.getThrown();
     if (throwable != null) {
-      if (builder instanceof ExtendedLogRecordBuilder) {
-        ((ExtendedLogRecordBuilder) builder).setException(throwable);
-      } else {
-        attributes.put(ExceptionAttributes.EXCEPTION_TYPE, throwable.getClass().getName());
-        attributes.put(ExceptionAttributes.EXCEPTION_MESSAGE, throwable.getMessage());
-        StringWriter writer = new StringWriter();
-        throwable.printStackTrace(new PrintWriter(writer));
-        attributes.put(ExceptionAttributes.EXCEPTION_STACKTRACE, writer.toString());
-      }
+      // this cast is safe within java agent instrumentation
+      ((ExtendedLogRecordBuilder) builder).setException(throwable);
     }
     captureMdcAttributes(attributes);