Skip to content

Commit 4159613

Browse files
committed
(chore) class access cleanup from review
1 parent 0009c4f commit 4159613

File tree

8 files changed

+12
-60
lines changed

8 files changed

+12
-60
lines changed

instrumentation/ratpack/ratpack-1.7/javaagent/build.gradle.kts

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,11 @@ muzzle {
88
module.set("ratpack-core")
99
versions.set("[1.7.0,)")
1010
}
11+
fail {
12+
group.set("io.ratpack")
13+
module.set("ratpack-core")
14+
versions.set("[1.0,1.7)")
15+
}
1116
}
1217

1318
dependencies {
@@ -19,18 +24,11 @@ dependencies {
1924
testLibrary("io.ratpack:ratpack-test:1.7.0")
2025
testImplementation(project(":instrumentation:ratpack:ratpack-1.4:testing"))
2126
testInstrumentation(project(":instrumentation:ratpack:ratpack-1.4:javaagent"))
22-
23-
if (JavaVersion.current().isCompatibleWith(JavaVersion.VERSION_11)) {
24-
testImplementation("com.sun.activation:jakarta.activation:1.2.2")
25-
}
2627
}
2728

2829
tasks {
2930
withType<Test>().configureEach {
3031
systemProperty("testLatestDeps", findProperty("testLatestDeps") as Boolean)
32+
jvmArgs("-Dotel.instrumentation.common.experimental.controller-telemetry.enabled=true")
3133
}
3234
}
33-
34-
tasks.withType<Test>().configureEach {
35-
jvmArgs("-Dotel.instrumentation.common.experimental.controller-telemetry.enabled=true")
36-
}

instrumentation/ratpack/ratpack-1.7/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/ratpack/v1_7/RatpackInstrumentationModule.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,6 @@ public ElementMatcher.Junction<ClassLoader> classLoaderMatcher() {
3838
public List<TypeInstrumentation> typeInstrumentations() {
3939
return asList(
4040
new DefaultExecControllerInstrumentation(),
41-
new ServerRegistryInstrumentation(),
4241
new HttpClientInstrumentation(),
4342
new RequestActionSupportInstrumentation());
4443
}

instrumentation/ratpack/ratpack-1.7/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/ratpack/v1_7/ServerRegistryInstrumentation.java

Lines changed: 0 additions & 44 deletions
This file was deleted.

instrumentation/ratpack/ratpack-1.7/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/ratpack/v1_7/RatpackPooledHttpClientTest.java

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -38,9 +38,8 @@ protected void configure(HttpClientTestOptions.Builder optionsBuilder) {
3838
HttpClientTestOptions.DEFAULT_EXPECTED_CLIENT_SPAN_NAME_MAPPER);
3939
optionsBuilder.setClientSpanErrorMapper(
4040
(uri, exception) -> {
41-
if (uri.toString().equals("https://192.0.2.1/")) {
42-
return new ConnectTimeoutException("Connect timeout (PT2S) connecting to " + uri);
43-
} else if (OS.WINDOWS.isCurrentOs() && uri.toString().equals("http://localhost:61/")) {
41+
if (uri.toString().equals("https://192.0.2.1/")
42+
|| (OS.WINDOWS.isCurrentOs() && uri.toString().equals("http://localhost:61/"))) {
4443
return new ConnectTimeoutException("Connect timeout (PT2S) connecting to " + uri);
4544
} else if (uri.getPath().equals("/read-timeout")) {
4645
return new HttpClientReadTimeoutException(

instrumentation/ratpack/ratpack-1.7/library/src/main/java/io/opentelemetry/instrumentation/ratpack/v1_7/internal/RatpackGetter.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
* This class is internal and is hence not for public use. Its APIs are unstable and can change at
1414
* any time.
1515
*/
16-
public enum RatpackGetter implements TextMapGetter<Request> {
16+
enum RatpackGetter implements TextMapGetter<Request> {
1717
INSTANCE;
1818

1919
@Override

instrumentation/ratpack/ratpack-1.7/library/src/main/java/io/opentelemetry/instrumentation/ratpack/v1_7/internal/RatpackHttpAttributesGetter.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
* This class is internal and is hence not for public use. Its APIs are unstable and can change at
1818
* any time.
1919
*/
20-
public enum RatpackHttpAttributesGetter implements HttpServerAttributesGetter<Request, Response> {
20+
enum RatpackHttpAttributesGetter implements HttpServerAttributesGetter<Request, Response> {
2121
INSTANCE;
2222

2323
@Override

instrumentation/ratpack/ratpack-1.7/library/src/main/java/io/opentelemetry/instrumentation/ratpack/v1_7/internal/RatpackHttpClientAttributesGetter.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
* This class is internal and is hence not for public use. Its APIs are unstable and can change at
1616
* any time.
1717
*/
18-
public enum RatpackHttpClientAttributesGetter
18+
enum RatpackHttpClientAttributesGetter
1919
implements HttpClientAttributesGetter<RequestSpec, HttpResponse> {
2020
INSTANCE;
2121

instrumentation/ratpack/ratpack-1.7/library/src/main/java/io/opentelemetry/instrumentation/ratpack/v1_7/internal/RequestHeaderSetter.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
* This class is internal and is hence not for public use. Its APIs are unstable and can change at
1414
* any time.
1515
*/
16-
public enum RequestHeaderSetter implements TextMapSetter<RequestSpec> {
16+
enum RequestHeaderSetter implements TextMapSetter<RequestSpec> {
1717
INSTANCE;
1818

1919
@Override

0 commit comments

Comments
 (0)