pr review

Author: zeitlinger

instrumentation/logback/logback-appender-1.0/library/src/main/java/io/opentelemetry/instrumentation/logback/appender/v1_0/internal/LoggingEventMapper.java

@@ -639,41 +639,18 @@ private static boolean supportsLogstashStructuredArguments() {
   @NoMuzzle
   private void captureLogstashStructuredArguments(LogRecordBuilder builder, Object[] arguments) {
     for (Object argument : arguments) {
-      if (isLogstashSingleStructuredArgument(argument)) {
-        captureLogstashSingleStructuredArgument(builder, argument);
-      }
-      if (isLogstashMapStructuredArgument(argument)) {
-        captureLogstashMapStructuredArgument(builder, argument);
+      if (isLogstashStructuredArgument(argument)) {
+        captureLogstashMarker(builder, argument);
       }
     }
   }
 
   @NoMuzzle
-  private static boolean isLogstashSingleStructuredArgument(Object argument) {
-    // StructuredArguments implement the marker interface, so we can check for it
-    // without importing the class directly (which may not be available at runtime)
-    return argument instanceof SingleFieldAppendingMarker;
-  }
-
-  @NoMuzzle
-  private void captureLogstashSingleStructuredArgument(LogRecordBuilder builder, Object argument) {
-    // StructuredArguments created by v() or keyValue() extend SingleFieldAppendingMarker
-    // which has getFieldName() and provides field value via reflection
-    SingleFieldAppendingMarker marker = (SingleFieldAppendingMarker) argument;
-    captureLogstashMarker(builder, marker);
-  }
-
-  @NoMuzzle
-  private static boolean isLogstashMapStructuredArgument(Object argument) {
+  private static boolean isLogstashStructuredArgument(Object argument) {
     // StructuredArguments implement the marker interface, so we can check for it
     // without importing the class directly (which may not be available at runtime)
-    return argument instanceof MapEntriesAppendingMarker;
-  }
-
-  @NoMuzzle
-  private void captureLogstashMapStructuredArgument(LogRecordBuilder builder, Object argument) {
-    MapEntriesAppendingMarker marker = (MapEntriesAppendingMarker) argument;
-    captureLogstashMarker(builder, marker);
+    return argument instanceof SingleFieldAppendingMarker
+        || argument instanceof MapEntriesAppendingMarker;
   }
 
   private interface FieldReader {