Skip to content

Commit 4443006

Browse files
committed
remove OpenSearchInstrumenterFactory.java
1 parent e90f611 commit 4443006

File tree

3 files changed

+19
-34
lines changed

3 files changed

+19
-34
lines changed

instrumentation/opensearch/opensearch-java-3.0/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/opensearch/v3_0/OpenSearchAttributesGetter.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,10 +12,9 @@
1212
final class OpenSearchAttributesGetter
1313
implements DbClientAttributesGetter<OpenSearchRequest, Void> {
1414

15-
@SuppressWarnings("deprecation") // using deprecated DbSystemIncubatingValues
1615
@Override
1716
public String getDbSystem(OpenSearchRequest request) {
18-
return DbIncubatingAttributes.DbSystemIncubatingValues.OPENSEARCH;
17+
return DbIncubatingAttributes.DbSystemNameIncubatingValues.OPENSEARCH;
1918
}
2019

2120
@Override

instrumentation/opensearch/opensearch-java-3.0/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/opensearch/v3_0/OpenSearchInstrumenterFactory.java

Lines changed: 0 additions & 30 deletions
This file was deleted.

instrumentation/opensearch/opensearch-java-3.0/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/opensearch/v3_0/OpenSearchSingletons.java

Lines changed: 18 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,15 +5,31 @@
55

66
package io.opentelemetry.javaagent.instrumentation.opensearch.v3_0;
77

8+
import io.opentelemetry.api.GlobalOpenTelemetry;
9+
import io.opentelemetry.instrumentation.api.incubator.semconv.db.DbClientAttributesExtractor;
10+
import io.opentelemetry.instrumentation.api.incubator.semconv.db.DbClientMetrics;
11+
import io.opentelemetry.instrumentation.api.incubator.semconv.db.DbClientSpanNameExtractor;
812
import io.opentelemetry.instrumentation.api.instrumenter.Instrumenter;
13+
import io.opentelemetry.instrumentation.api.instrumenter.SpanKindExtractor;
914

1015
public final class OpenSearchSingletons {
11-
private static final Instrumenter<OpenSearchRequest, Void> INSTRUMENTER =
12-
OpenSearchInstrumenterFactory.create("io.opentelemetry.opensearch-java-3.0");
16+
private static final Instrumenter<OpenSearchRequest, Void> INSTRUMENTER = createInstrumenter();
1317

1418
public static Instrumenter<OpenSearchRequest, Void> instrumenter() {
1519
return INSTRUMENTER;
1620
}
1721

22+
private static Instrumenter<OpenSearchRequest, Void> createInstrumenter() {
23+
OpenSearchAttributesGetter dbClientAttributesGetter = new OpenSearchAttributesGetter();
24+
25+
return Instrumenter.<OpenSearchRequest, Void>builder(
26+
GlobalOpenTelemetry.get(),
27+
"io.opentelemetry.opensearch-java-3.0",
28+
DbClientSpanNameExtractor.create(dbClientAttributesGetter))
29+
.addAttributesExtractor(DbClientAttributesExtractor.create(dbClientAttributesGetter))
30+
.addOperationMetrics(DbClientMetrics.get())
31+
.buildInstrumenter(SpanKindExtractor.alwaysClient());
32+
}
33+
1834
private OpenSearchSingletons() {}
1935
}

0 commit comments

Comments
 (0)