Skip to content

Commit 4690642

Browse files
authored
Assert parent span of response span in dropwizard test (#15286)
1 parent 83d1cad commit 4690642

File tree

1 file changed

+2
-4
lines changed
  • instrumentation/dropwizard/dropwizard-testing/src/test/java/io/opentelemetry/javaagent/instrumentation/dropwizard

1 file changed

+2
-4
lines changed

instrumentation/dropwizard/dropwizard-testing/src/test/java/io/opentelemetry/javaagent/instrumentation/dropwizard/DropwizardTest.java

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,6 @@
3131
import io.opentelemetry.instrumentation.testing.junit.http.HttpServerTestOptions;
3232
import io.opentelemetry.instrumentation.testing.junit.http.ServerEndpoint;
3333
import io.opentelemetry.sdk.testing.assertj.SpanDataAssert;
34-
import io.opentelemetry.sdk.trace.data.SpanData;
3534
import io.opentelemetry.sdk.trace.data.StatusData;
3635
import java.net.URI;
3736
import java.net.URISyntaxException;
@@ -129,10 +128,9 @@ private static String getEndpointName(ServerEndpoint endpoint) {
129128

130129
@Override
131130
protected SpanDataAssert assertResponseSpan(
132-
SpanDataAssert span, SpanData parentSpan, String method, ServerEndpoint endpoint) {
133-
span.satisfies(spanData -> assertThat(spanData.getName()).endsWith(".sendError"))
131+
SpanDataAssert span, String method, ServerEndpoint endpoint) {
132+
return span.satisfies(spanData -> assertThat(spanData.getName()).endsWith(".sendError"))
134133
.hasKind(INTERNAL);
135-
return span;
136134
}
137135

138136
public static class TestApp extends Application<Configuration> {

0 commit comments

Comments
 (0)