docs: add comment explaining TypeConverter version check in JFinal instrumentation

pepeshore · pepeshore · commit 47a29a7309e3 · 2025-11-13T15:44:05.000+08:00
Add clarification that TypeConverter was moved from com.jfinal.core to
com.jfinal.core.converter after version 3.2, explaining the classloader matcher logic.

Change-Id: Id796d3e1798573a93c4fba0f30a5dd101fa73538
diff --git a/instrumentation/jfinal-3.2/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/jfinal/v3_2/JFinalInstrumentationModule.java b/instrumentation/jfinal-3.2/javaagent/src/main/java/io/opentelemetry/javaagent/instrumentation/jfinal/v3_2/JFinalInstrumentationModule.java
@@ -23,6 +23,8 @@ public JFinalInstrumentationModule() {
 
   @Override
   public ElementMatcher.Junction<ClassLoader> classLoaderMatcher() {
+    // In version 3.2, TypeConverter is moved from com.jfinal.core
+    // to com.jfinal.core.converter
     return not(hasClassesNamed("com.jfinal.core.TypeConverter"));
   }
 

Original file line number	Diff line number	Diff line change
`@@ -23,6 +23,8 @@ public JFinalInstrumentationModule() {`
`23`	`23`
`24`	`24`	`@Override`
`25`	`25`	`public ElementMatcher.Junction<ClassLoader> classLoaderMatcher() {`
	`26`	`+ // In version 3.2, TypeConverter is moved from com.jfinal.core`
	`27`	`+ // to com.jfinal.core.converter`
`26`	`28`	`return not(hasClassesNamed("com.jfinal.core.TypeConverter"));`
`27`	`29`	`}`
`28`	`30`