Fix tests on Windows

Author: trask

instrumentation/akka/akka-http-10.0/javaagent/src/test/scala/io/opentelemetry/javaagent/instrumentation/akkahttp/AkkaHttpClientInstrumentationTest.scala

@@ -26,6 +26,7 @@ import io.opentelemetry.instrumentation.testing.junit.http.{
 import java.net.URI
 import java.util
 import java.util.concurrent.Executor
+import org.junit.jupiter.api.condition.OS
 import org.junit.jupiter.api.extension.RegisterExtension
 
 import java.util.function.BiFunction
@@ -119,6 +120,11 @@ class AkkaHttpClientInstrumentationTest
   ): Unit = {
     options.disableTestRedirects()
     options.disableTestNonStandardHttpMethod()
+    // On Windows, non-routable addresses timeout instead of failing fast, causing test timeout
+    // before the HTTP client can create a span, resulting in only the parent span.
+    if (OS.WINDOWS.isCurrentOs()) {
+      options.disableTestRemoteConnection()
+    }
     // singleConnection test would require instrumentation to support requests made through pools
     // (newHostConnectionPool, superPool, etc), which is currently not supported.
     options.setSingleConnectionFactory(

instrumentation/async-http-client/async-http-client-2.0/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/asynchttpclient/v2_0/AsyncHttpClientTest.java

@@ -23,6 +23,7 @@
 import org.asynchttpclient.RequestBuilder;
 import org.asynchttpclient.Response;
 import org.asynchttpclient.uri.Uri;
+import org.junit.jupiter.api.condition.OS;
 import org.junit.jupiter.api.extension.RegisterExtension;
 
 class AsyncHttpClientTest extends AbstractHttpClientTest<Request> {
@@ -97,5 +98,10 @@ public void onThrowable(Throwable throwable) {
   protected void configure(HttpClientTestOptions.Builder optionsBuilder) {
     optionsBuilder.disableTestRedirects();
     optionsBuilder.spanEndsAfterBody();
+    // On Windows, non-routable addresses timeout instead of failing fast, causing test timeout
+    // before the HTTP client can create a span, resulting in only the parent span.
+    if (OS.WINDOWS.isCurrentOs()) {
+      optionsBuilder.disableTestRemoteConnection();
+    }
   }
 }

instrumentation/finagle-http-23.11/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/finaglehttp/v23_11/ClientTest.java

@@ -34,6 +34,7 @@
 import io.opentelemetry.javaagent.instrumentation.finaglehttp.v23_11.Utils.ClientType;
 import java.net.ConnectException;
 import java.net.URI;
+import java.nio.channels.ClosedChannelException;
 import java.util.Collections;
 import java.util.HashSet;
 import java.util.Locale;
@@ -143,7 +144,12 @@ protected void configure(HttpClientTestOptions.Builder optionsBuilder) {
                 .cause()
                 .isInstanceOf(ConnectionFailedException.class)
                 .cause()
-                .isInstanceOf(ConnectException.class);
+                // On Linux: ConnectException, On Windows: ClosedChannelException
+                .satisfies(
+                    cause -> {
+                      assertThat(cause)
+                          .isInstanceOfAny(ConnectException.class, ClosedChannelException.class);
+                    });
             error = error.getCause().getCause().getCause();
           } else if (uri.getPath().endsWith("/read-timeout")) {
             // not a connect() exception like the above, so is not wrapped as above;

instrumentation/lettuce/lettuce-5.0/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/lettuce/v5_0/LettuceAsyncClientTest.java

@@ -56,6 +56,7 @@
 import org.junit.jupiter.api.AfterAll;
 import org.junit.jupiter.api.BeforeAll;
 import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.condition.OS;
 
 @SuppressWarnings("deprecation") // using deprecated semconv
 class LettuceAsyncClientTest extends AbstractLettuceClientTest {
@@ -149,6 +150,11 @@ void testConnectExceptionInsideTheConnectionFuture() {
 
     assertThat(exception).isInstanceOf(ExecutionException.class);
 
+    // Windows includes "getsockopt: " in the connection refused message
+    String windowsGetsockopt = OS.WINDOWS.isCurrentOs() ? "getsockopt: " : "";
+    String expectedMessage =
+        "Connection refused: " + windowsGetsockopt + host + "/" + ip + ":" + incorrectPort;
+
     testing.waitAndAssertTraces(
         trace ->
             trace.hasSpansSatisfyingExactly(
@@ -171,12 +177,7 @@ void testConnectExceptionInsideTheConnectionFuture() {
                                             "io.netty.channel.AbstractChannel.AnnotatedConnectException"),
                                         equalTo(
                                             AttributeKey.stringKey("exception.message"),
-                                            "Connection refused: "
-                                                + host
-                                                + "/"
-                                                + ip
-                                                + ":"
-                                                + incorrectPort),
+                                            expectedMessage),
                                         satisfies(
                                             AttributeKey.stringKey("exception.stacktrace"),
                                             val -> val.isNotNull())))));

instrumentation/lettuce/lettuce-5.0/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/lettuce/v5_0/LettuceSyncClientTest.java

@@ -32,6 +32,7 @@
 import org.junit.jupiter.api.AfterAll;
 import org.junit.jupiter.api.BeforeAll;
 import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.condition.OS;
 
 @SuppressWarnings("deprecation") // using deprecated semconv
 class LettuceSyncClientTest extends AbstractLettuceClientTest {
@@ -109,6 +110,11 @@ void testConnectException() {
 
     assertThat(exception).isInstanceOf(RedisConnectionException.class);
 
+    // Windows includes "getsockopt: " in the connection refused message
+    String windowsGetsockopt = OS.WINDOWS.isCurrentOs() ? "getsockopt: " : "";
+    String expectedMessage =
+        "Connection refused: " + windowsGetsockopt + host + "/" + ip + ":" + incorrectPort;
+
     testing.waitAndAssertTraces(
         trace ->
             trace.hasSpansSatisfyingExactly(
@@ -131,12 +137,7 @@ void testConnectException() {
                                             "io.netty.channel.AbstractChannel.AnnotatedConnectException"),
                                         equalTo(
                                             AttributeKey.stringKey("exception.message"),
-                                            "Connection refused: "
-                                                + host
-                                                + "/"
-                                                + ip
-                                                + ":"
-                                                + incorrectPort),
+                                            expectedMessage),
                                         satisfies(
                                             AttributeKey.stringKey("exception.stacktrace"),
                                             val -> val.isNotNull())))));

instrumentation/netty/netty-3.8/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/netty/v3_8/client/Netty38ClientTest.java

@@ -31,6 +31,7 @@
 import java.util.Map;
 import java.util.Set;
 import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.condition.OS;
 import org.junit.jupiter.api.extension.RegisterExtension;
 
 class Netty38ClientTest extends AbstractHttpClientTest<Request> {
@@ -139,6 +140,11 @@ protected void configure(HttpClientTestOptions.Builder optionsBuilder) {
     optionsBuilder.disableTestHttps();
     optionsBuilder.disableTestReadTimeout();
 
+    // On Windows, non-routable addresses behave differently, causing test failures.
+    if (OS.WINDOWS.isCurrentOs()) {
+      optionsBuilder.disableTestRemoteConnection();
+    }
+
     optionsBuilder.setExpectedClientSpanNameMapper(
         (uri, method) -> {
           // unopened port or non routable address

instrumentation/netty/netty-4.0/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/netty/v4_0/client/Netty40ClientTest.java

@@ -39,6 +39,7 @@
 import java.util.concurrent.TimeUnit;
 import org.jetbrains.annotations.NotNull;
 import org.junit.jupiter.api.AfterAll;
+import org.junit.jupiter.api.condition.OS;
 import org.junit.jupiter.api.extension.RegisterExtension;
 
 class Netty40ClientTest extends AbstractHttpClientTest<DefaultFullHttpRequest> {
@@ -141,6 +142,10 @@ protected void configure(HttpClientTestOptions.Builder optionsBuilder) {
 
     optionsBuilder.setExpectedClientSpanNameMapper(Netty40ClientTest::expectedClientSpanName);
     optionsBuilder.setHttpAttributes(Netty40ClientTest::httpAttributes);
+    // On Windows, non-routable addresses behave differently, causing test failures.
+    if (OS.WINDOWS.isCurrentOs()) {
+      optionsBuilder.disableTestRemoteConnection();
+    }
   }
 
   private static int getPort(URI uri) {

instrumentation/netty/netty-4.1/testing/src/main/java/io/opentelemetry/instrumentation/netty/v4_1/AbstractNetty41ClientTest.java

@@ -30,6 +30,7 @@
 import java.util.concurrent.TimeUnit;
 import java.util.concurrent.TimeoutException;
 import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.condition.OS;
 
 public abstract class AbstractNetty41ClientTest
     extends AbstractHttpClientTest<DefaultFullHttpRequest> {
@@ -113,6 +114,11 @@ protected void configure(HttpClientTestOptions.Builder optionsBuilder) {
 
     optionsBuilder.disableTestRedirects();
     optionsBuilder.spanEndsAfterBody();
+    // On Windows, non-routable addresses behave differently (SSL handshake vs CONNECT span,
+    // or no error thrown), causing platform-specific test failures.
+    if (OS.WINDOWS.isCurrentOs()) {
+      optionsBuilder.disableTestRemoteConnection();
+    }
   }
 
   private static Set<AttributeKey<?>> getHttpAttributes(URI uri) {

instrumentation/powerjob-4.0/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/powerjob/v4_0/PowerJobBasicProcessorTest.java

@@ -23,6 +23,8 @@
 import java.util.List;
 import javax.sql.DataSource;
 import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.condition.DisabledOnOs;
+import org.junit.jupiter.api.condition.OS;
 import org.junit.jupiter.api.extension.RegisterExtension;
 import tech.powerjob.official.processors.impl.FileCleanupProcessor;
 import tech.powerjob.official.processors.impl.HttpProcessor;
@@ -172,6 +174,7 @@ void testMapReduceProcessor() throws Exception {
         });
   }
 
+  @DisabledOnOs(value = OS.WINDOWS, disabledReason = "ShellProcessor requires /bin/sh")
   @Test
   void testShellProcessor() throws Exception {
     long jobId = 1;

instrumentation/ratpack/ratpack-1.4/testing/src/main/java/io/opentelemetry/instrumentation/ratpack/client/AbstractRatpackHttpClientTest.java

@@ -141,6 +141,13 @@ protected void configure(HttpClientTestOptions.Builder optionsBuilder) {
     // these tests will pass, but they don't really test anything since REQUEST is Void
     optionsBuilder.disableTestReusedRequest();
 
+    // Connection error tests fail on Windows due to different exception handling by Netty
+    // even with the unwrapping and error mapping logic above
+    if (OS.WINDOWS.isCurrentOs()) {
+      optionsBuilder.disableTestConnectionFailure();
+      optionsBuilder.disableTestRemoteConnection();
+    }
+
     optionsBuilder.spanEndsAfterBody();
   }
 
@@ -169,6 +176,15 @@ protected boolean useNettyClientAttributes() {
   }
 
   private static Throwable nettyClientSpanErrorMapper(URI uri, Throwable exception) {
+    // On Windows, Netty wraps exceptions in AbstractChannel.AnnotatedConnectException
+    // Unwrap to get the actual exception type
+    if (OS.WINDOWS.isCurrentOs()
+        && exception != null
+        && exception.getClass().getName().contains("AnnotatedConnectException")
+        && exception.getCause() != null) {
+      exception = exception.getCause();
+    }
+
     if (uri.toString().equals("https://192.0.2.1/")) {
       return new ConnectTimeoutException(
           "connection timed out"