Skip to content

Commit 4a8ff50

Browse files
committed
fix ci & test
1 parent 0634f1e commit 4a8ff50

File tree

6 files changed

+11
-24
lines changed

6 files changed

+11
-24
lines changed

instrumentation/kafka/kafka-clients/kafka-clients-0.11/testing/src/main/java/io/opentelemetry/instrumentation/kafkaclients/common/v0_11/internal/KafkaClientBaseTest.java

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@
1717
import static io.opentelemetry.semconv.incubating.MessagingIncubatingAttributes.MESSAGING_MESSAGE_BODY_SIZE;
1818
import static io.opentelemetry.semconv.incubating.MessagingIncubatingAttributes.MESSAGING_OPERATION;
1919
import static io.opentelemetry.semconv.incubating.MessagingIncubatingAttributes.MESSAGING_SYSTEM;
20+
import static org.assertj.core.api.Assertions.assertThat;
2021

2122
import io.opentelemetry.api.common.AttributeKey;
2223
import io.opentelemetry.sdk.testing.assertj.AttributeAssertion;
@@ -74,10 +75,7 @@ protected static AttributeAssertion bootstrapServersAssertion() {
7475
MESSAGING_KAFKA_BOOTSTRAP_SERVERS,
7576
listAssert -> {
7677
if (Boolean.getBoolean("otel.instrumentation.kafka.experimental-span-attributes")) {
77-
listAssert
78-
.isNotEmpty()
79-
.allSatisfy(
80-
server -> org.assertj.core.api.Assertions.assertThat(server).isNotEmpty());
78+
listAssert.isNotEmpty().allSatisfy(server -> assertThat(server).isNotEmpty());
8179
} else {
8280
listAssert.isNullOrEmpty();
8381
}

instrumentation/kafka/kafka-streams-0.11/javaagent/src/test/java/io/opentelemetry/javaagent/instrumentation/kafkastreams/KafkaStreamsBaseTest.java

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88
import static io.opentelemetry.sdk.testing.assertj.OpenTelemetryAssertions.satisfies;
99
import static java.util.Arrays.asList;
1010
import static java.util.Collections.singleton;
11+
import static org.assertj.core.api.Assertions.assertThat;
1112

1213
import com.google.common.collect.ImmutableMap;
1314
import io.opentelemetry.api.common.AttributeKey;
@@ -64,10 +65,7 @@ protected static AttributeAssertion bootstrapServersAssertion() {
6465
MESSAGING_KAFKA_BOOTSTRAP_SERVERS,
6566
listAssert -> {
6667
if (Boolean.getBoolean("otel.instrumentation.kafka.experimental-span-attributes")) {
67-
listAssert
68-
.isNotEmpty()
69-
.allSatisfy(
70-
server -> org.assertj.core.api.Assertions.assertThat(server).isNotEmpty());
68+
listAssert.isNotEmpty().allSatisfy(server -> assertThat(server).isNotEmpty());
7169
} else {
7270
listAssert.isNullOrEmpty();
7371
}

instrumentation/reactor/reactor-kafka-1.0/testing/src/main/java/io/opentelemetry/javaagent/instrumentation/reactor/kafka/v1_0/AbstractReactorKafkaTest.java

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@
2020
import static io.opentelemetry.semconv.incubating.MessagingIncubatingAttributes.MESSAGING_SYSTEM;
2121
import static java.util.Arrays.asList;
2222
import static java.util.Collections.singleton;
23+
import static org.assertj.core.api.Assertions.assertThat;
2324

2425
import io.opentelemetry.api.common.AttributeKey;
2526
import io.opentelemetry.api.trace.SpanKind;
@@ -79,10 +80,7 @@ protected static AttributeAssertion bootstrapServersAssertion() {
7980
MESSAGING_KAFKA_BOOTSTRAP_SERVERS,
8081
listAssert -> {
8182
if (Boolean.getBoolean("otel.instrumentation.kafka.experimental-span-attributes")) {
82-
listAssert
83-
.isNotEmpty()
84-
.allSatisfy(
85-
server -> org.assertj.core.api.Assertions.assertThat(server).isNotEmpty());
83+
listAssert.isNotEmpty().allSatisfy(server -> assertThat(server).isNotEmpty());
8684
} else {
8785
listAssert.isNullOrEmpty();
8886
}

instrumentation/spring/spring-kafka-2.7/testing/src/main/java/io/opentelemetry/testing/AbstractSpringKafkaTest.java

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -52,10 +52,7 @@ protected static AttributeAssertion bootstrapServersAssertion() {
5252
MESSAGING_KAFKA_BOOTSTRAP_SERVERS,
5353
listAssert -> {
5454
if (Boolean.getBoolean("otel.instrumentation.kafka.experimental-span-attributes")) {
55-
listAssert
56-
.isNotEmpty()
57-
.allSatisfy(
58-
server -> org.assertj.core.api.Assertions.assertThat(server).isNotEmpty());
55+
listAssert.isNotEmpty().allSatisfy(server -> assertThat(server).isNotEmpty());
5956
} else {
6057
listAssert.isNullOrEmpty();
6158
}

instrumentation/vertx/vertx-kafka-client-3.6/testing/src/main/java/io/opentelemetry/javaagent/instrumentation/vertx/kafka/AbstractVertxKafkaTest.java

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@
1717
import static io.opentelemetry.semconv.incubating.MessagingIncubatingAttributes.MESSAGING_OPERATION;
1818
import static io.opentelemetry.semconv.incubating.MessagingIncubatingAttributes.MESSAGING_SYSTEM;
1919
import static io.opentelemetry.semconv.incubating.MessagingIncubatingAttributes.MessagingSystemIncubatingValues.KAFKA;
20+
import static org.assertj.core.api.Assertions.assertThat;
2021
import static org.junit.jupiter.api.Assertions.assertTrue;
2122

2223
import io.opentelemetry.api.common.AttributeKey;
@@ -67,10 +68,7 @@ protected static AttributeAssertion bootstrapServersAssertion() {
6768
MESSAGING_KAFKA_BOOTSTRAP_SERVERS,
6869
listAssert -> {
6970
if (Boolean.getBoolean("otel.instrumentation.kafka.experimental-span-attributes")) {
70-
listAssert
71-
.isNotEmpty()
72-
.allSatisfy(
73-
server -> org.assertj.core.api.Assertions.assertThat(server).isNotEmpty());
71+
listAssert.isNotEmpty().allSatisfy(server -> assertThat(server).isNotEmpty());
7472
} else {
7573
listAssert.isNullOrEmpty();
7674
}

smoke-tests-otel-starter/spring-boot-common/src/main/java/io/opentelemetry/spring/smoketest/AbstractKafkaSpringStarterSmokeTest.java

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77

88
import static io.opentelemetry.sdk.testing.assertj.OpenTelemetryAssertions.equalTo;
99
import static io.opentelemetry.sdk.testing.assertj.OpenTelemetryAssertions.satisfies;
10+
import static org.assertj.core.api.Assertions.assertThat;
1011

1112
import io.opentelemetry.api.OpenTelemetry;
1213
import io.opentelemetry.api.common.AttributeKey;
@@ -40,10 +41,7 @@ protected static AttributeAssertion bootstrapServersAssertion() {
4041
return satisfies(
4142
MESSAGING_KAFKA_BOOTSTRAP_SERVERS,
4243
listAssert ->
43-
listAssert
44-
.isNotEmpty()
45-
.allSatisfy(
46-
server -> org.assertj.core.api.Assertions.assertThat(server).isNotEmpty()));
44+
listAssert.isNotEmpty().allSatisfy(server -> assertThat(server).isNotEmpty()));
4745
}
4846

4947
@SuppressWarnings("deprecation") // using deprecated semconv

0 commit comments

Comments
 (0)